From: Greg KH <gregkh@linuxfoundation.org>
To: yangerkun <yangerkun@huawei.com>
Cc: sfrench@samba.org, pc@manguebit.com, lsahlber@redhat.com,
sprasad@microsoft.com, tom@talpey.com, dhowells@redhat.com,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
stable@kernel.org, nspmangalore@gmail.com, ematsumiya@suse.de,
yangerkun@huaweicloud.com
Subject: Re: [PATCH v3] cifs: fix pagecache leak when do writepages
Date: Thu, 11 Sep 2025 13:17:42 +0200 [thread overview]
Message-ID: <2025091157-imply-dugout-3b39@gregkh> (raw)
In-Reply-To: <ff670765-d3e2-bc0a-5cef-c18757fe3ee0@huawei.com>
On Thu, Sep 11, 2025 at 07:09:30PM +0800, yangerkun wrote:
>
>
> 在 2025/9/11 18:53, Greg KH 写道:
> > On Thu, Sep 11, 2025 at 11:22:57AM +0800, yangerkun wrote:
> > > Hello,
> > >
> > > In stable version 6.6, IO operations for CIFS cause system memory leaks
> > > shortly after starting; our test case triggers this issue, and other users
> > > have reported it as well [1].
> > >
> > > This problem does not occur in the mainline kernel after commit 3ee1a1fc3981
> > > ("cifs: Cut over to using netfslib") (v6.10-rc1), but backporting this fix
> > > to stable versions 6.6 through 6.9 is challenging. Therefore, I have decided
> > > to address the issue with a separate patch.
> > >
> > > Hi Greg,
> > >
> > > I have reviewed [2] to understand the process for submitting patches to
> > > stable branches. However, this patch may not fit their criteria since it is
> > > not a backport from mainline. Is there anything else I should do to make
> > > this patch appear more formal?
> >
> > Yes, please include the info as to why this is not a backport from
> > upstream, and why it can only go into this one specific tree and get the
> > developers involved to agree with this.
>
> Alright, the reason I favor this single patch is that the mainline solution
> involves a major refactor [1] to change the I/O path to netfslib.
> Backporting it would cause many conflicts, and such a large patch set would
> introduce numerous KABI changes. Therefore, this single patch is provided
> here instead...
There is no stable kernel api, sorry, that is not a valid reason. And
we've taken large patch sets in the past.
But if you can get the maintainers of the code to agree that this is the
best solution, we'll be glad to take it.
thanks,
greg k-h
next prev parent reply other threads:[~2025-09-11 11:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 3:01 [PATCH v3] cifs: fix pagecache leak when do writepages Yang Erkun
2025-09-11 3:22 ` yangerkun
2025-09-11 10:53 ` Greg KH
2025-09-11 11:09 ` yangerkun
2025-09-11 11:17 ` Greg KH [this message]
2025-09-11 11:25 ` yangerkun
2025-09-11 11:40 ` Shyam Prasad N
2025-09-11 15:45 ` Enzo Matsumiya
2025-09-11 16:40 ` Steve French
2025-09-11 17:10 ` Greg KH
2025-09-11 16:31 ` David Howells
2025-09-11 16:38 ` Greg KH
2025-09-11 16:25 ` David Howells
2025-09-11 18:17 ` Matthew Wilcox
2025-09-12 1:12 ` yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025091157-imply-dugout-3b39@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dhowells@redhat.com \
--cc=ematsumiya@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=nspmangalore@gmail.com \
--cc=pc@manguebit.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=stable@kernel.org \
--cc=tom@talpey.com \
--cc=yangerkun@huawei.com \
--cc=yangerkun@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox