Re: [PATCH v2] RFC: ksmbd: Create module_kobject if builtin

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Oct 24, 2025 at 08:05:29AM +0200, Linus Walleij wrote:
> On Fri, Oct 24, 2025 at 7:08 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> 
> > > Since I actually turn off modules and compile all my modules
> > > into the kernel, I can't change the script to just check
> > > cat /lib/modules/$(uname -r)/modules.builtin | grep ksmbd
> > > either: no /lib/modules directory.
> >
> > Then do something else to determine if ksmbd is in the running kernel,
> > don't rely on a modules sysfs file like that.
> 
> There really isn't a good way for a script to detect if a module is
> compiled-in that I know of.

That should be a per-feature type of thing.  Surely ksmbd has some sort
of user/kernel api that can be tested if it is present or not?

> You did suggest simply create this file also for compiled-in
> module, always:
> https://lore.kernel.org/all/2025060254-unscathed-junior-1b43@gregkh/
> 
> It just seemed a bit cluttery, but maybe the $subject approach
> is even more cluttery by creating special cases.

Yes, let's not special-case this, either make it so that every module
name shows up in sysfs (if it has a parameter or not), or keep it as-is.
Don't do module-specific hacks like you are proposing here.

thanks,

greg k-h