From: chenxiaosong.chenxiaosong@linux.dev
To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org,
linkinjeon@samba.org, christophe.jaillet@wanadoo.fr
Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
ChenXiaoSong <chenxiaosong@kylinos.cn>
Subject: [PATCH v4 00/24] smb: move duplicate definitions to common header file
Date: Mon, 27 Oct 2025 15:12:52 +0800 [thread overview]
Message-ID: <20251027071316.3468472-1-chenxiaosong.chenxiaosong@linux.dev> (raw)
From: ChenXiaoSong <chenxiaosong@kylinos.cn>
The following patches from v3 have already been merged into the mainline:
- smb/server: fix possible memory leak in smb2_read(): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6fced056d2cc8d01b326e6fcfabaacb9850b71a4
- smb/server: fix possible refcount leak in smb2_sess_setup(): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=379510a815cb2e64eb0a379cb62295d6ade65df0
- smb: move some duplicate definitions to common/cifsglob.h: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d877470b59910b5c50383d634dda3782386bba51
In order to maintain the code more easily, move some duplicate definitions
to common header file.
Add some MS documentation references for macro and struct definitions.
v3->v4:
- The following modifications were made according to Namjae's suggestions.
- Create patch #01, rename it to "smbglob.h".
- Patch #02 #03 #04: move definitions to common/smbglob.h instead of common/cifsglob.h.
- Patch #05: do not move "BAD_PROT".
- Patch #05 ~ #15: move definitions to common/smb1pdu.h instead of common/cifspdu.h.
- Create #16 ~ #19: move some durable handle structures to common/smb2pdu.h.
- Fix warnings from script checkpatch.pl: WARNING: Prefer __packed over __attribute__((packed)).
- Update some commit message descriptions.
v3: https://lore.kernel.org/all/20251014071917.3004573-1-chenxiaosong.chenxiaosong@linux.dev/
ChenXiaoSong (16):
smb: move some duplicate definitions to common/smb1pdu.h
smb: move file access permission bits definitions to common/smb1pdu.h
smb: move SMB frame definitions to common/smb1pdu.h
smb: move FILE_SYSTEM_ATTRIBUTE_INFO to common/smb1pdu.h
smb: move FILE_SYSTEM_DEVICE_INFO to common/smb1pdu.h
smb: move FILE_SYSTEM_INFO to common/smb1pdu.h
smb: move FILE_DIRECTORY_INFO to common/smb1pdu.h
smb: move FILE_FULL_DIRECTORY_INFO to common/smb1pdu.h
smb: move FILE_BOTH_DIRECTORY_INFO to common/smb1pdu.h
smb: move SEARCH_ID_FULL_DIR_INFO to common/smb1pdu.h
smb: move FILE_SYSTEM_POSIX_INFO to common/smb1pdu.h
smb: move create_durable_req_v2 to common/smb2pdu.h
smb: move create_durable_handle_reconnect_v2 to common/smb2pdu.h
smb: move create_durable_rsp_v2 to common/smb2pdu.h
smb/server: remove create_durable_reconn_req
smb: move smb2_file_network_open_info to common/smb2pdu.h
ZhangGuoDong (8):
smb: rename common/cifsglob.h to common/smbglob.h
smb: move smb_version_values to common/smbglob.h
smb: move get_rfc1002_len() to common/smbglob.h
smb: move SMB1_PROTO_NUMBER to common/smbglob.h
smb: move smb_sockaddr_in and smb_sockaddr_in6 to common/smb2pdu.h
smb: move copychunk definitions to common/smb2pdu.h
smb: move resume_key_ioctl_rsp to common/smb2pdu.h
smb: move some duplicate definitions to common/smb2pdu.h
fs/smb/client/cifsacl.c | 4 +-
fs/smb/client/cifsglob.h | 30 +--
fs/smb/client/cifspdu.h | 435 +-------------------------------
fs/smb/client/cifssmb.c | 10 +-
fs/smb/client/cifstransport.c | 8 +-
fs/smb/client/connect.c | 2 +-
fs/smb/client/misc.c | 2 +-
fs/smb/client/smb2ops.c | 18 +-
fs/smb/client/smb2pdu.c | 14 +-
fs/smb/client/smb2pdu.h | 112 ---------
fs/smb/common/cifsglob.h | 30 ---
fs/smb/common/smb1pdu.h | 462 ++++++++++++++++++++++++++++++++++
fs/smb/common/smb2pdu.h | 144 ++++++++++-
fs/smb/common/smbglob.h | 68 +++++
fs/smb/server/oplock.c | 8 +-
fs/smb/server/smb2misc.c | 2 +-
fs/smb/server/smb2ops.c | 38 +--
fs/smb/server/smb2pdu.c | 136 +++++-----
fs/smb/server/smb2pdu.h | 107 --------
fs/smb/server/smb_common.c | 10 +-
fs/smb/server/smb_common.h | 291 +--------------------
fs/smb/server/smbacl.c | 2 +-
fs/smb/server/vfs.c | 2 +-
23 files changed, 800 insertions(+), 1135 deletions(-)
delete mode 100644 fs/smb/common/cifsglob.h
create mode 100644 fs/smb/common/smb1pdu.h
create mode 100644 fs/smb/common/smbglob.h
--
2.43.0
next reply other threads:[~2025-10-27 7:15 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 7:12 chenxiaosong.chenxiaosong [this message]
2025-10-27 7:12 ` [PATCH v4 01/24] smb: rename common/cifsglob.h to common/smbglob.h chenxiaosong.chenxiaosong
2025-10-27 7:12 ` [PATCH v4 02/24] smb: move smb_version_values " chenxiaosong.chenxiaosong
2025-10-27 7:12 ` [PATCH v4 03/24] smb: move get_rfc1002_len() " chenxiaosong.chenxiaosong
2025-10-27 7:12 ` [PATCH v4 04/24] smb: move SMB1_PROTO_NUMBER " chenxiaosong.chenxiaosong
2025-10-27 7:12 ` [PATCH v4 05/24] smb: move some duplicate definitions to common/smb1pdu.h chenxiaosong.chenxiaosong
2025-10-28 3:42 ` Namjae Jeon
2025-10-28 3:57 ` ChenXiaoSong
2025-10-28 4:02 ` Namjae Jeon
2025-10-31 9:50 ` ChenXiaoSong
2025-10-31 9:57 ` Fwd: " ChenXiaoSong
2025-10-27 7:12 ` [PATCH v4 06/24] smb: move file access permission bits " chenxiaosong.chenxiaosong
2025-10-28 3:36 ` Namjae Jeon
2025-10-28 3:50 ` ChenXiaoSong
[not found] ` <CAH2r5mudENVd0MxrYCidsovUJsk0FheTgkUTXm34UT_+hGNz=g@mail.gmail.com>
[not found] ` <713404c4-9bc0-4410-9004-5337b6b2ddee@linux.dev>
[not found] ` <CAH2r5mv-NxRHr70Tt7kd4Wc89NCtUqqxj7HOtK7st1esNS5GAw@mail.gmail.com>
2025-10-29 1:17 ` ChenXiaoSong
2025-10-29 1:21 ` Steve French
2025-10-27 7:12 ` [PATCH v4 07/24] smb: move SMB frame " chenxiaosong.chenxiaosong
2025-10-27 7:13 ` [PATCH v4 08/24] smb: move FILE_SYSTEM_ATTRIBUTE_INFO " chenxiaosong.chenxiaosong
2025-10-27 7:13 ` [PATCH v4 09/24] smb: move FILE_SYSTEM_DEVICE_INFO " chenxiaosong.chenxiaosong
2025-10-27 7:13 ` [PATCH v4 10/24] smb: move FILE_SYSTEM_INFO " chenxiaosong.chenxiaosong
2025-10-27 7:13 ` [PATCH v4 11/24] smb: move FILE_DIRECTORY_INFO " chenxiaosong.chenxiaosong
2025-10-27 7:13 ` [PATCH v4 12/24] smb: move FILE_FULL_DIRECTORY_INFO " chenxiaosong.chenxiaosong
2025-10-27 7:13 ` [PATCH v4 13/24] smb: move FILE_BOTH_DIRECTORY_INFO " chenxiaosong.chenxiaosong
2025-10-28 3:39 ` Namjae Jeon
2025-10-28 4:04 ` ChenXiaoSong
2025-10-27 7:13 ` [PATCH v4 14/24] smb: move SEARCH_ID_FULL_DIR_INFO " chenxiaosong.chenxiaosong
2025-10-28 3:50 ` Namjae Jeon
2025-10-27 7:21 ` [PATCH v4 15/24] smb: move FILE_SYSTEM_POSIX_INFO " chenxiaosong.chenxiaosong
2025-10-31 1:41 ` ChenXiaoSong
2025-10-31 1:53 ` Steve French
2025-10-31 1:53 ` Steve French
2025-10-31 2:24 ` ChenXiaoSong
2025-10-31 2:31 ` ChenXiaoSong
2025-10-31 2:33 ` Steve French
2025-10-27 7:21 ` [PATCH v4 16/24] smb: move create_durable_req_v2 to common/smb2pdu.h chenxiaosong.chenxiaosong
2025-10-27 7:21 ` [PATCH v4 17/24] smb: move create_durable_handle_reconnect_v2 " chenxiaosong.chenxiaosong
2025-10-27 7:22 ` [PATCH v4 18/24] smb: move create_durable_rsp_v2 " chenxiaosong.chenxiaosong
2025-10-27 7:22 ` [PATCH v4 19/24] smb/server: remove create_durable_reconn_req chenxiaosong.chenxiaosong
2025-10-29 3:54 ` Namjae Jeon
2025-10-29 4:17 ` ChenXiaoSong
2025-10-27 7:22 ` [PATCH v4 20/24] smb: move smb2_file_network_open_info to common/smb2pdu.h chenxiaosong.chenxiaosong
2025-10-27 7:22 ` [PATCH v4 21/24] smb: move smb_sockaddr_in and smb_sockaddr_in6 " chenxiaosong.chenxiaosong
2025-10-27 7:22 ` [PATCH v4 22/24] smb: move copychunk definitions " chenxiaosong.chenxiaosong
2025-10-27 7:22 ` [PATCH v4 23/24] smb: move resume_key_ioctl_rsp " chenxiaosong.chenxiaosong
2025-10-27 7:22 ` [PATCH v4 24/24] smb: move some duplicate definitions " chenxiaosong.chenxiaosong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027071316.3468472-1-chenxiaosong.chenxiaosong@linux.dev \
--to=chenxiaosong.chenxiaosong@linux.dev \
--cc=chenxiaosong@kylinos.cn \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linkinjeon@kernel.org \
--cc=linkinjeon@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).