From: chenxiaosong.chenxiaosong@linux.dev
To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org,
linkinjeon@samba.org, christophe.jaillet@wanadoo.fr
Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
ChenXiaoSong <chenxiaosong@kylinos.cn>
Subject: [PATCH v5 00/14] smb: move duplicate definitions to common header file
Date: Sun, 2 Nov 2025 15:30:45 +0800 [thread overview]
Message-ID: <20251102073059.3681026-1-chenxiaosong.chenxiaosong@linux.dev> (raw)
From: ChenXiaoSong <chenxiaosong@kylinos.cn>
The following patches from v3 have already been merged into the mainline:
- 6fced056d2cc smb/server: fix possible memory leak in smb2_read()
- 379510a815cb smb/server: fix possible refcount leak in smb2_sess_setup()
- d877470b5991 smb: move some duplicate definitions to common/cifsglob.h
The following patches from v4 have been applied to [the ksmbd-for-next-next branch](https://git.samba.org/?p=ksmbd.git;a=shortlog;h=refs/heads/ksmbd-for-next-next):
- smb: move resume_key_ioctl_rsp to common/smb2pdu.h
- smb: move copychunk definitions to common/smb2pdu.h
- smb: move smb_sockaddr_in and smb_sockaddr_in6 to common/smb2pdu.h
- smb: move SMB1_PROTO_NUMBER to common/smbglob.h
- smb: move get_rfc1002_len() to common/smbglob.h
- smb: move smb_version_values to common/smbglob.h
- smb: rename common/cifsglob.h to common/smbglob.h
In order to maintain the code more easily, move some duplicate definitions
to common header file.
Add some MS documentation references for macro and struct definitions.
I will test these code changes with smbtorure and xfstests as soon as possible.
By cleaning the common definitions for client and server, I've become more
familiar with the MS documentation, which I believe will be very useful for
developing SMB features soon.
v4->v5:
- The following modifications were made according to Namjae's and Steve's suggestions.
- Create patch #01 #02 #08.
- Patch #07: move struct smb_hdr to common/smb2pdu.h, do not move SET_FILE_READ_RIGHTS and SET_FILE_WRITE_RIGHTS.
- Patch #09 ~ #12: move definitions to common/fscc.h
- Patch #10: include all changes that only rename structures in this patch.
- Patch #11 #12: some cleanups.
v4: https://lore.kernel.org/all/20251027071316.3468472-1-chenxiaosong.chenxiaosong@linux.dev/
ChenXiaoSong (13):
smb/client: fix CAP_BULK_TRANSFER value
smb: move MAX_CIFS_SMALL_BUFFER_SIZE to common/smbglob.h
smb: move create_durable_req_v2 to common/smb2pdu.h
smb: move create_durable_handle_reconnect_v2 to common/smb2pdu.h
smb: move create_durable_rsp_v2 to common/smb2pdu.h
smb/server: remove create_durable_reconn_req
smb: move SMB_NEGOTIATE_REQ to common/smb2pdu.h
smb: move list of FileSystemAttributes to common/fscc.h
smb: move some duplicate struct definitions to common/fscc.h
smb: move FILE_SYSTEM_SIZE_INFO to common/fscc.h
smb: move FILE_SYSTEM_ATTRIBUTE_INFO to common/fscc.h
smb: do some cleanups
smb: fix some warnings reported by scripts/checkpatch.pl
ZhangGuoDong (1):
smb: move some duplicate definitions to common/smb2pdu.h
fs/smb/client/cifsglob.h | 1 +
fs/smb/client/cifspdu.h | 593 +++++++++++--------------------------
fs/smb/client/cifssmb.c | 12 +-
fs/smb/client/connect.c | 4 +-
fs/smb/client/inode.c | 4 +-
fs/smb/client/ntlmssp.h | 8 +-
fs/smb/client/readdir.c | 12 +-
fs/smb/client/reparse.h | 8 +-
fs/smb/client/rfc1002pdu.h | 8 +-
fs/smb/client/smb1ops.c | 2 +-
fs/smb/client/smb2inode.c | 2 +-
fs/smb/client/smb2pdu.c | 16 +-
fs/smb/client/smb2pdu.h | 69 -----
fs/smb/common/fscc.h | 179 +++++++++++
fs/smb/common/smb2pdu.h | 221 +++++++++++++-
fs/smb/common/smbacl.h | 8 +-
fs/smb/common/smbglob.h | 4 +
fs/smb/server/oplock.c | 8 +-
fs/smb/server/smb2ops.c | 6 +-
fs/smb/server/smb2pdu.c | 116 ++++----
fs/smb/server/smb2pdu.h | 68 -----
fs/smb/server/smb_common.h | 237 +--------------
fs/smb/server/vfs.c | 2 +-
23 files changed, 682 insertions(+), 906 deletions(-)
create mode 100644 fs/smb/common/fscc.h
--
2.43.0
next reply other threads:[~2025-11-02 7:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-02 7:30 chenxiaosong.chenxiaosong [this message]
2025-11-02 7:30 ` [PATCH v5 01/14] smb/client: fix CAP_BULK_TRANSFER value chenxiaosong.chenxiaosong
2025-11-02 7:30 ` [PATCH v5 02/14] smb: move MAX_CIFS_SMALL_BUFFER_SIZE to common/smbglob.h chenxiaosong.chenxiaosong
2025-11-02 7:30 ` [PATCH v5 03/14] smb: move create_durable_req_v2 to common/smb2pdu.h chenxiaosong.chenxiaosong
2025-11-02 7:30 ` [PATCH v5 04/14] smb: move create_durable_handle_reconnect_v2 " chenxiaosong.chenxiaosong
2025-11-02 7:30 ` [PATCH v5 05/14] smb: move create_durable_rsp_v2 " chenxiaosong.chenxiaosong
2025-11-02 7:30 ` [PATCH v5 06/14] smb/server: remove create_durable_reconn_req chenxiaosong.chenxiaosong
2025-11-02 7:30 ` [PATCH v5 07/14] smb: move some duplicate definitions to common/smb2pdu.h chenxiaosong.chenxiaosong
2025-11-04 4:04 ` ChenXiaoSong
2025-11-02 7:30 ` [PATCH v5 08/14] smb: move SMB_NEGOTIATE_REQ " chenxiaosong.chenxiaosong
2025-11-02 7:30 ` [PATCH v5 09/14] smb: move list of FileSystemAttributes to common/fscc.h chenxiaosong.chenxiaosong
2025-11-02 7:30 ` [PATCH v5 10/14] smb: move some duplicate struct definitions " chenxiaosong.chenxiaosong
2025-11-02 7:30 ` [PATCH v5 11/14] smb: move FILE_SYSTEM_SIZE_INFO " chenxiaosong.chenxiaosong
2025-11-02 7:30 ` [PATCH v5 12/14] smb: move FILE_SYSTEM_ATTRIBUTE_INFO " chenxiaosong.chenxiaosong
2025-11-02 7:30 ` [PATCH v5 13/14] smb: do some cleanups chenxiaosong.chenxiaosong
2025-11-02 7:30 ` [PATCH v5 14/14] smb: fix some warnings reported by scripts/checkpatch.pl chenxiaosong.chenxiaosong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251102073059.3681026-1-chenxiaosong.chenxiaosong@linux.dev \
--to=chenxiaosong.chenxiaosong@linux.dev \
--cc=chenxiaosong@kylinos.cn \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linkinjeon@kernel.org \
--cc=linkinjeon@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).