From: Christian Brauner <brauner@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-aio@kvack.org, linux-unionfs@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-nfs@vger.kernel.org,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
cgroups@vger.kernel.org, netdev@vger.kernel.org,
Christian Brauner <brauner@kernel.org>
Subject: [PATCH 06/16] backing-file: use credential guards for splice write
Date: Mon, 03 Nov 2025 12:26:54 +0100 [thread overview]
Message-ID: <20251103-work-creds-guards-simple-v1-6-a3e156839e7f@kernel.org> (raw)
In-Reply-To: <20251103-work-creds-guards-simple-v1-0-a3e156839e7f@kernel.org>
Use credential guards for scoped credential override with automatic
restoration on scope exit.
Signed-off-by: Christian Brauner <brauner@kernel.org>
---
fs/backing-file.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/fs/backing-file.c b/fs/backing-file.c
index 8ebc62f49bad..9c63a3368b66 100644
--- a/fs/backing-file.c
+++ b/fs/backing-file.c
@@ -303,7 +303,6 @@ ssize_t backing_file_splice_write(struct pipe_inode_info *pipe,
size_t len, unsigned int flags,
struct backing_file_ctx *ctx)
{
- const struct cred *old_cred;
ssize_t ret;
if (WARN_ON_ONCE(!(out->f_mode & FMODE_BACKING)))
@@ -316,11 +315,11 @@ ssize_t backing_file_splice_write(struct pipe_inode_info *pipe,
if (ret)
return ret;
- old_cred = override_creds(ctx->cred);
- file_start_write(out);
- ret = out->f_op->splice_write(pipe, out, &iocb->ki_pos, len, flags);
- file_end_write(out);
- revert_creds(old_cred);
+ scoped_with_creds(ctx->cred) {
+ file_start_write(out);
+ ret = out->f_op->splice_write(pipe, out, &iocb->ki_pos, len, flags);
+ file_end_write(out);
+ }
if (ctx->end_write)
ctx->end_write(iocb, ret);
--
2.47.3
next prev parent reply other threads:[~2025-11-03 11:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 11:26 [PATCH 00/16] credentials guards: the easy cases Christian Brauner
2025-11-03 11:26 ` [PATCH 01/16] cred: add {scoped_}with_creds() guards Christian Brauner
2025-11-03 11:26 ` [PATCH 02/16] aio: use credential guards Christian Brauner
2025-11-03 11:26 ` [PATCH 03/16] backing-file: use credential guards for reads Christian Brauner
2025-11-03 11:26 ` [PATCH 04/16] backing-file: use credential guards for writes Christian Brauner
2025-11-03 13:24 ` Amir Goldstein
2025-11-03 11:26 ` [PATCH 05/16] backing-file: use credential guards for splice read Christian Brauner
2025-11-03 11:26 ` Christian Brauner [this message]
2025-11-03 11:26 ` [PATCH 07/16] backing-file: use credential guards for mmap Christian Brauner
2025-11-03 11:26 ` [PATCH 08/16] binfmt_misc: use credential guards Christian Brauner
2025-11-03 11:26 ` [PATCH 09/16] erofs: " Christian Brauner
2025-11-03 11:26 ` [PATCH 10/16] nfs: use credential guards in nfs_local_call_read() Christian Brauner
2025-11-03 11:26 ` [PATCH 11/16] nfs: use credential guards in nfs_local_call_write() Christian Brauner
2025-11-03 11:27 ` [PATCH 12/16] nfs: use credential guards in nfs_idmap_get_key() Christian Brauner
2025-11-03 11:27 ` [PATCH 13/16] smb: use credential guards in cifs_get_spnego_key() Christian Brauner
2025-11-03 11:27 ` [PATCH 14/16] act: use credential guards in acct_write_process() Christian Brauner
2025-11-03 23:04 ` Linus Torvalds
2025-11-04 9:45 ` Amir Goldstein
2025-11-04 11:40 ` Christian Brauner
2025-11-03 11:27 ` [PATCH 15/16] cgroup: use credential guards in cgroup_attach_permissions() Christian Brauner
2025-11-03 11:27 ` [PATCH 16/16] net/dns_resolver: use credential guards in dns_query() Christian Brauner
2025-11-03 13:29 ` [PATCH 00/16] credentials guards: the easy cases Amir Goldstein
2025-11-03 14:53 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103-work-creds-guards-simple-v1-6-a3e156839e7f@kernel.org \
--to=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-aio@kvack.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).