Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Steve French <sfrench@samba.org>
Cc: David Howells <dhowells@redhat.com>,
	Paulo Alcantara <pc@manguebit.org>,
	Enzo Matsumiya <ematsumiya@suse.de>,
	linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 04/18] cifs: Scripted clean up fs/smb/client/cifs_unicode.h
Date: Thu, 11 Dec 2025 12:16:58 +0000	[thread overview]
Message-ID: <20251211121715.759074-6-dhowells@redhat.com> (raw)
In-Reply-To: <20251211121715.759074-2-dhowells@redhat.com>

Remove externs, correct argument names and reformat declarations.

Signed-off-by: David Howells <dhowells@redhat.com>
cc: Steve French <sfrench@samba.org>
cc: Paulo Alcantara <pc@manguebit.org>
cc: Enzo Matsumiya <ematsumiya@suse.de>
cc: linux-cifs@vger.kernel.org
cc: linux-fsdevel@vger.kernel.org
cc: linux-kernel@vger.kernel.org
---
 fs/smb/client/cifs_unicode.h | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/fs/smb/client/cifs_unicode.h b/fs/smb/client/cifs_unicode.h
index 6e4b99786498..9249db3b78c3 100644
--- a/fs/smb/client/cifs_unicode.h
+++ b/fs/smb/client/cifs_unicode.h
@@ -55,19 +55,20 @@
 #define SFU_MAP_UNI_RSVD	2
 
 int cifs_from_utf16(char *to, const __le16 *from, int tolen, int fromlen,
-		    const struct nls_table *cp, int map_type);
+		    const struct nls_table *codepage, int map_type);
 int cifs_utf16_bytes(const __le16 *from, int maxbytes,
 		     const struct nls_table *codepage);
-int cifs_strtoUTF16(__le16 *, const char *, int, const struct nls_table *);
+int cifs_strtoUTF16(__le16 *to, const char *from, int len,
+		    const struct nls_table *codepage);
 char *cifs_strndup_from_utf16(const char *src, const int maxlen,
 			      const bool is_unicode,
 			      const struct nls_table *codepage);
-extern int cifsConvertToUTF16(__le16 *target, const char *source, int maxlen,
-			      const struct nls_table *cp, int mapChars);
-extern int cifs_remap(struct cifs_sb_info *cifs_sb);
-extern __le16 *cifs_strndup_to_utf16(const char *src, const int maxlen,
-				     int *utf16_len, const struct nls_table *cp,
-				     int remap);
+int cifsConvertToUTF16(__le16 *target, const char *source, int srclen,
+		       const struct nls_table *cp, int map_chars);
+int cifs_remap(struct cifs_sb_info *cifs_sb);
+__le16 *cifs_strndup_to_utf16(const char *src, const int maxlen,
+			      int *utf16_len, const struct nls_table *cp,
+			      int remap);
 wchar_t cifs_toupper(wchar_t in);
 
 #endif /* _CIFS_UNICODE_H */


  parent reply	other threads:[~2025-12-11 12:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-11 12:16 [PATCH 00/18] cifs: Scripted header file cleanup David Howells
2025-12-11 12:16 ` [PATCH 01/18] cifs: Scripted clean up fs/smb/client/cached_dir.h David Howells
2025-12-11 12:16 ` [PATCH 02/18] cifs: Scripted clean up fs/smb/client/dfs.h David Howells
2025-12-11 12:16 ` [PATCH 03/18] cifs: Scripted clean up fs/smb/client/cifsproto.h David Howells
2025-12-11 12:16 ` David Howells [this message]
2025-12-11 12:16 ` [PATCH 05/18] cifs: Scripted clean up fs/smb/client/netlink.h David Howells
2025-12-11 12:17 ` [PATCH 06/18] cifs: Scripted clean up fs/smb/client/cifsfs.h David Howells
2025-12-11 12:17 ` [PATCH 07/18] cifs: Scripted clean up fs/smb/client/dfs_cache.h David Howells
2025-12-11 12:17 ` [PATCH 08/18] cifs: Scripted clean up fs/smb/client/dns_resolve.h David Howells
2025-12-11 12:17 ` [PATCH 09/18] cifs: Scripted clean up fs/smb/client/cifsglob.h David Howells
2025-12-11 12:17 ` [PATCH 10/18] cifs: Scripted clean up fs/smb/client/fscache.h David Howells
2025-12-11 12:17 ` [PATCH 11/18] cifs: Scripted clean up fs/smb/client/fs_context.h David Howells
2025-12-11 12:17 ` [PATCH 12/18] cifs: Scripted clean up fs/smb/client/cifs_spnego.h David Howells
2025-12-11 12:17 ` [PATCH 13/18] cifs: Scripted clean up fs/smb/client/compress.h David Howells
2025-12-11 12:17 ` [PATCH 14/18] cifs: Scripted clean up fs/smb/client/cifs_swn.h David Howells
2025-12-11 12:17 ` [PATCH 15/18] cifs: Scripted clean up fs/smb/client/cifs_debug.h David Howells
2025-12-11 12:17 ` [PATCH 16/18] cifs: Scripted clean up fs/smb/client/smb2proto.h David Howells
2025-12-11 12:17 ` [PATCH 17/18] cifs: Scripted clean up fs/smb/client/reparse.h David Howells
2025-12-11 12:17 ` [PATCH 18/18] cifs: Scripted clean up fs/smb/client/ntlmssp.h David Howells
2025-12-16 21:57 ` [PATCH 00/18] cifs: Scripted header file cleanup Paulo Alcantara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251211121715.759074-6-dhowells@redhat.com \
    --to=dhowells@redhat.com \
    --cc=ematsumiya@suse.de \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pc@manguebit.org \
    --cc=sfrench@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox