From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04A89241690 for ; Thu, 25 Dec 2025 02:11:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766628721; cv=none; b=iltlNRcWpFQQPRqE5OBgi0w4/TUEMH+PmugrRlEHOEhrihG1sVFwekYXEFM31TTICGIer6xx9loDOKbhXvQsBqrsNQurzY1kuj+OJG4bnkoUO8QOtJP1jfpJTSAVm+EM2mqwgbVa04M6FjnZ7Z5yrkfBtk/hk1gYWrL+4vOXNkQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766628721; c=relaxed/simple; bh=MMp84n3lBvw+h28eBEGsuaKkwHZsrm952EwPfM4fK94=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tSLX6mkHK835/xHai+20JG6tJuCls3pOCK3fP7QeuV2t0rMXWQrYr3hVija5GE6KiZWeFPFNYvFTaQuLip4uMdYAReQk826fJH2dRA/+5eqS4hykqnCzXspt1L9fgO8f4Lbt3t9WeE3GdFZ8k7gDMcEDG39FXDgrP4AmZqNy5mY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=GAA9yNFM; arc=none smtp.client-ip=91.218.175.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="GAA9yNFM" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1766628717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4CeaKNQbmdyqWpjpgN1OWDp8T9hYSDfhTSTpAu8RtXE=; b=GAA9yNFMGBgvz3q2BGdE8k7U++qi0AYtrCkLCegILN+1hjg0lIF1kRaBAd2SUQfqt4LnMC 7T0lB73lVe+PTUnE+MdEI24WfXdAHKq6m6v5eGPuU6MX8JFD5wAkuj4kIJ4RkJkVRBE1yT DqmwGep84SabwUL2PwN67QX8RkFkUKQ= From: chenxiaosong.chenxiaosong@linux.dev To: smfrench@gmail.com, linkinjeon@kernel.org, pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com, bharathsm@microsoft.com, senozhatsky@chromium.org, dhowells@redhat.com Cc: linux-cifs@vger.kernel.org, ChenXiaoSong Subject: [PATCH v6 5/5] smb/client: introduce KUnit test to check search result of smb2_error_map_table Date: Thu, 25 Dec 2025 10:10:35 +0800 Message-ID: <20251225021035.656639-6-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251225021035.656639-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251225021035.656639-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: ChenXiaoSong The KUnit test are executed when cifs.ko is loaded. Just like `fs/ext4/mballoc.c` includes `fs/ext4/mballoc-test.c`. `smb2maperror.c` also includes `smb2maperror_test.c`, allowing KUnit tests to access any functions and variables in `smb2maperror.c`. The maperror_test_check_search() checks whether all elements can be correctly found in the array. Suggested-by: David Howells Signed-off-by: ChenXiaoSong --- fs/smb/Kconfig | 17 +++++++++++ fs/smb/client/smb2maperror.c | 4 +++ fs/smb/client/smb2maperror_test.c | 48 +++++++++++++++++++++++++++++++ 3 files changed, 69 insertions(+) create mode 100644 fs/smb/client/smb2maperror_test.c diff --git a/fs/smb/Kconfig b/fs/smb/Kconfig index ef425789fa6a..85f7ad5fbc5e 100644 --- a/fs/smb/Kconfig +++ b/fs/smb/Kconfig @@ -9,3 +9,20 @@ config SMBFS tristate default y if CIFS=y || SMB_SERVER=y default m if CIFS=m || SMB_SERVER=m + +config SMB_KUNIT_TESTS + tristate "KUnit tests for SMB" if !KUNIT_ALL_TESTS + depends on SMBFS && KUNIT + default KUNIT_ALL_TESTS + help + This builds the SMB KUnit tests. + + KUnit tests run during boot and output the results to the debug log + in TAP format (https://testanything.org/). Only useful for kernel devs + running KUnit test harness and are not for inclusion into a production + build. + + For more information on KUnit and unit tests in general please refer + to the KUnit documentation in Documentation/dev-tools/kunit/. + + If unsure, say N. diff --git a/fs/smb/client/smb2maperror.c b/fs/smb/client/smb2maperror.c index b0241e6adbb6..b7005f0a9e2c 100644 --- a/fs/smb/client/smb2maperror.c +++ b/fs/smb/client/smb2maperror.c @@ -113,3 +113,7 @@ int __init smb2_init_maperror(void) return 0; } + +#if IS_ENABLED(CONFIG_SMB_KUNIT_TESTS) +#include "smb2maperror_test.c" +#endif /* CONFIG_SMB_KUNIT_TESTS */ diff --git a/fs/smb/client/smb2maperror_test.c b/fs/smb/client/smb2maperror_test.c new file mode 100644 index 000000000000..6ac6cdac623b --- /dev/null +++ b/fs/smb/client/smb2maperror_test.c @@ -0,0 +1,48 @@ +// SPDX-License-Identifier: LGPL-2.1 +/* + * + * KUnit tests of SMB2 maperror + * + * Copyright (C) 2025 KylinSoft Co., Ltd. All rights reserved. + * Author(s): ChenXiaoSong + * + */ + +#include + +static void +test_cmp_map(struct kunit *test, struct status_to_posix_error *expect) +{ + struct status_to_posix_error *result; + + result = smb2_get_err_map(expect->smb2_status); + KUNIT_EXPECT_PTR_NE(test, NULL, result); + KUNIT_EXPECT_EQ(test, expect->smb2_status, result->smb2_status); + KUNIT_EXPECT_EQ(test, expect->posix_error, result->posix_error); + KUNIT_EXPECT_STREQ(test, expect->status_string, result->status_string); +} + +static void maperror_test_check_search(struct kunit *test) +{ + unsigned int i; + struct status_to_posix_error expect; + + for (i = 0; i < ARRAY_SIZE(smb2_error_map_table); i++) { + expect = smb2_error_map_table[i]; + test_cmp_map(test, &expect); + } +} + +static struct kunit_case maperror_test_cases[] = { + KUNIT_CASE(maperror_test_check_search), + {} +}; + +static struct kunit_suite maperror_suite = { + .name = "smb2_maperror", + .test_cases = maperror_test_cases, +}; + +kunit_test_suite(maperror_suite); + +MODULE_LICENSE("GPL"); -- 2.43.0