[PATCH v2 00/12] smb: improve search speed of SMB1 maperror

huiwen.he
2026-04-01T07:30:21Z

v1->v2:
- Sort arrays at build time
- Merge nt_errs to ntstatus_to_dos_map
- Check if arrays are sorted in smb1_init_maperror()

v1: https://lore.kernel.org/linux-cifs/20251208062100.3268777-1-chenxiaosong.chenxiaosong@linux.dev/

When searching for the last element, the comparison counts are shown in the table below:

+--------------------+--------+--------+
| |Before |After |
| |Patchset|Patchset|
+--------------------+--------+--------+
| ntstatus_to_dos_map| 533 | 9 |
+--------------------+--------+--------+
|mapping_table_ERRDOS| 34 | 5 |
+--------------------+--------+--------+
|mapping_table_ERRSRV| 37 | 5 |
+--------------------+--------+--------+

The following patches from v1 have already been merged into the mainline:
- a71a4aab4834 smb/client: add parentheses to NT error code definitions containing bitwise OR operator
- a9adafd40165 smb/client: add 4 NT error code definitions
- 98def4eb0244 smb/server: remove unused nterr.h
- 9f99caa8950a smb/client: fix NT_STATUS_UNABLE_TO_FREE_VM value
- b2b50fca34da smb/client: fix NT_STATUS_DEVICE_DOOR_OPEN value
- a1237c203f17 smb/client: fix NT_STATUS_NO_DATA_DETECTED value

Huiwen He (8):
smb/client: annotate nterr.h with DOS error codes
smb/client: autogenerate SMB1 NT status to DOS error mapping
smb/client: replace nt_errs with ntstatus_to_dos_map
smb/client: refactor ntstatus_to_dos() to return mapping entry
smb/client: use binary search for NT status to DOS mapping
smb/client: annotate smberr.h with POSIX error codes
smb/client: autogenerate SMB1 DOS/SRV to POSIX error mapping
smb/client: use binary search for SMB1 DOS/SRV error mapping

Youling Tang (4):
smb/client: check if ntstatus_to_dos_map is sorted
smb/client: introduce KUnit test to check ntstatus_to_dos_map search
smb/client: check if SMB1 DOS/SRV error mapping arrays are sorted
smb/client: introduce KUnit tests to check DOS/SRV err mapping search

fs/smb/client/.gitignore | 3 +
fs/smb/client/Kconfig | 11 +
fs/smb/client/Makefile | 25 +-
fs/smb/client/cifsfs.c | 6 +
fs/smb/client/gen_smb1_mapping | 109 +++
fs/smb/client/nterr.c | 704 -------------------
fs/smb/client/nterr.h | 1082 +++++++++++++++--------------
fs/smb/client/smb1maperror.c | 873 +++++------------------
fs/smb/client/smb1maperror_test.c | 83 +++
fs/smb/client/smb1proto.h | 9 +
fs/smb/client/smberr.h | 415 +++++++----
11 files changed, 1232 insertions(+), 2088 deletions(-)
create mode 100644 fs/smb/client/gen_smb1_mapping
delete mode 100644 fs/smb/client/nterr.c
create mode 100644 fs/smb/client/smb1maperror_test.c

--
2.52.0