From: huiwen.he@linux.dev
To: smfrench@gmail.com, linkinjeon@kernel.org, dhowells@redhat.com,
chenxiaosong@kylinos.cn, chenxiaosong@chenxiaosong.com,
tangyouling@kylinos.cn
Cc: linux-cifs@vger.kernel.org, Huiwen He <hehuiwen@kylinos.cn>
Subject: [PATCH v3 00/13] smb: improve search speed of SMB1 maperror
Date: Thu, 2 Apr 2026 14:18:26 +0000 [thread overview]
Message-ID: <20260402141839.461257-1-huiwen.he@linux.dev> (raw)
From: Huiwen He <hehuiwen@kylinos.cn>
v2->v3:
- All test cases passed for v3, please see ChenXiaoSong's blog: https://chenxiaosong.com/en/smb1maperror-test.html
- Patch #01: Correct the SMB1 mapping NT_STATUS_OBJECT_NAME_INVALID
- Patch #02 #10: gen_smb1_mapping: Enhance regex robustness to cover mixed-case prefixes (e.g., ErrNotALink), and match exact filenames to prevent mapping outputs to incorrect files.
- Patch #06: Add `__init` to `DEFINE_CHECK_SORT_FUNC`
- Patch #07: Use `KUNIT_ASSERT_NOT_NULL`
- Add patch #08: Move ERRnetlogonNotStarted to DOS error class
v2: https://lore.kernel.org/linux-cifs/20260401072912.355072-1-huiwen.he@linux.dev/
When searching for the last element, the comparison counts are shown in the table below:
+--------------------+--------+--------+
| |Before |After |
| |Patchset|Patchset|
+--------------------+--------+--------+
| ntstatus_to_dos_map| 533 | 9 |
+--------------------+--------+--------+
|mapping_table_ERRDOS| 34 | 5 |
+--------------------+--------+--------+
|mapping_table_ERRSRV| 37 | 5 |
+--------------------+--------+--------+
The following patches from v1 have already been merged into the mainline:
- a71a4aab4834 smb/client: add parentheses to NT error code definitions containing bitwise OR operator
- a9adafd40165 smb/client: add 4 NT error code definitions
- 98def4eb0244 smb/server: remove unused nterr.h
- 9f99caa8950a smb/client: fix NT_STATUS_UNABLE_TO_FREE_VM value
- b2b50fca34da smb/client: fix NT_STATUS_DEVICE_DOOR_OPEN value
- a1237c203f17 smb/client: fix NT_STATUS_NO_DATA_DETECTED value
Huiwen He (9):
smb/client: annotate nterr.h with DOS error codes
smb/client: autogenerate SMB1 NT status to DOS error mapping
smb/client: replace nt_errs with ntstatus_to_dos_map
smb/client: refactor ntstatus_to_dos() to return mapping entry
smb/client: use binary search for NT status to DOS mapping
smb/client: move ERRnetlogonNotStarted to DOS error class
smb/client: annotate smberr.h with POSIX error codes
smb/client: autogenerate SMB1 DOS/SRV to POSIX error mapping
smb/client: use binary search for SMB1 DOS/SRV error mapping
Youling Tang (4):
smb/client: check if ntstatus_to_dos_map is sorted
smb/client: introduce KUnit test to check ntstatus_to_dos_map search
smb/client: check if SMB1 DOS/SRV error mapping arrays are sorted
smb/client: introduce KUnit tests to check DOS/SRV err mapping search
fs/smb/client/.gitignore | 3 +
fs/smb/client/Kconfig | 11 +
fs/smb/client/Makefile | 25 +-
fs/smb/client/cifsfs.c | 6 +
fs/smb/client/gen_smb1_mapping | 112 +++
fs/smb/client/nterr.c | 704 -------------------
fs/smb/client/nterr.h | 1082 +++++++++++++++--------------
fs/smb/client/smb1maperror.c | 873 +++++------------------
fs/smb/client/smb1maperror_test.c | 83 +++
fs/smb/client/smb1proto.h | 9 +
fs/smb/client/smberr.h | 415 +++++++----
11 files changed, 1235 insertions(+), 2088 deletions(-)
create mode 100644 fs/smb/client/gen_smb1_mapping
delete mode 100644 fs/smb/client/nterr.c
create mode 100644 fs/smb/client/smb1maperror_test.c
--
2.53.0
next reply other threads:[~2026-04-02 14:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 14:18 huiwen.he [this message]
2026-04-02 14:18 ` [PATCH v3 01/13] smb/client: annotate nterr.h with DOS error codes huiwen.he
2026-04-02 22:35 ` Steve French
2026-04-02 14:18 ` [PATCH v3 02/13] smb/client: autogenerate SMB1 NT status to DOS error mapping huiwen.he
2026-04-02 14:18 ` [PATCH v3 03/13] smb/client: replace nt_errs with ntstatus_to_dos_map huiwen.he
2026-04-02 14:18 ` [PATCH v3 04/13] smb/client: refactor ntstatus_to_dos() to return mapping entry huiwen.he
2026-04-02 14:18 ` [PATCH v3 05/13] smb/client: use binary search for NT status to DOS mapping huiwen.he
2026-04-02 14:18 ` [PATCH v3 06/13] smb/client: check if ntstatus_to_dos_map is sorted huiwen.he
2026-04-02 14:18 ` [PATCH v3 07/13] smb/client: introduce KUnit test to check ntstatus_to_dos_map search huiwen.he
2026-04-02 14:18 ` [PATCH v3 08/13] smb/client: move ERRnetlogonNotStarted to DOS error class huiwen.he
2026-04-02 14:18 ` [PATCH v3 09/13] smb/client: annotate smberr.h with POSIX error codes huiwen.he
2026-04-02 14:18 ` [PATCH v3 10/13] smb/client: autogenerate SMB1 DOS/SRV to POSIX error mapping huiwen.he
2026-04-02 14:18 ` [PATCH v3 11/13] smb/client: use binary search for SMB1 DOS/SRV " huiwen.he
2026-04-02 14:18 ` [PATCH v3 12/13] smb/client: check if SMB1 DOS/SRV error mapping arrays are sorted huiwen.he
2026-04-02 14:18 ` [PATCH v3 13/13] smb/client: introduce KUnit tests to check DOS/SRV err mapping search huiwen.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402141839.461257-1-huiwen.he@linux.dev \
--to=huiwen.he@linux.dev \
--cc=chenxiaosong@chenxiaosong.com \
--cc=chenxiaosong@kylinos.cn \
--cc=dhowells@redhat.com \
--cc=hehuiwen@kylinos.cn \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
--cc=tangyouling@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox