From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6100D3ACA43; Thu, 7 May 2026 08:54:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778144055; cv=none; b=IU3x3nGqifQNS845eHr1DhOMLEDqbcD9ubwTb24sp+G1CxSy4kA/AAbzZ3m8G0tDPWAQ6OYH8KsCRrhGkdvRkpUDPcF40v0qBttwZUpGirYUiYWz020kyaecH5gi2gapdKlP87oSpt4oFTGEwBo27KOKueVeMFV8vmgLzoohD0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778144055; c=relaxed/simple; bh=MCKLEZC7Qx1FnQ0cZy8w8gaJqor/Oy2yvhPP57H1cWo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LZcUZesVZDiipH6uQvahmNRUi/EpA66PGpZF+Nk28zfhMydL+47NtwmZJUcM1e/xpUw6h7fdc6v6CvMPeHUkzj6ZNOIxWW5xUWGzP3cNMmzr9hFwK+K9AniwkHGB0dYvNWEpXHjfnZtJmDSEytmbM0GL8ERXfqGpLyhQiBH08vg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JbBPMCPb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JbBPMCPb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9B67C2BCB2; Thu, 7 May 2026 08:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778144054; bh=MCKLEZC7Qx1FnQ0cZy8w8gaJqor/Oy2yvhPP57H1cWo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JbBPMCPbvUWq/AZqNxKvw1CuQSSQUHimTJHyidbRuyHm7mNYOnBx/8TOo7rFB1sGo 8F6f7vAmzCP4vwvjMUXTtYKI+nfg/IVKWdlpK8FETxcnFX+hzT74qocmDOV7pbwzRB QL5RLNzJRaQRKUKlRQr+SqRQ/p4mVUZkJbLe4yCQukGLfxiJu5x2rRCDq1b9SrNiqK T6nOCWC2aZ2yHC6STir5iXWcoaIcY0lErPZy4ICvGusxTsqnEXFIvBA8vhH7+C6rko 6mlbrMFSvTJB/Q8r62FNMmTIEfOsugaBVLIm1aTn44BMJDvo4r/jnazCAaXDxQCoAm trYKTMWx+GtrA== From: Chuck Lever Date: Thu, 07 May 2026 04:53:00 -0400 Subject: [PATCH v14 07/15] hfsplus: Report case sensitivity in fileattr_get Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260507-case-sensitivity-v14-7-e62cc8200435@oracle.com> References: <20260507-case-sensitivity-v14-0-e62cc8200435@oracle.com> In-Reply-To: <20260507-case-sensitivity-v14-0-e62cc8200435@oracle.com> To: Al Viro , Christian Brauner , Jan Kara Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, hirofumi@mail.parknet.co.jp, linkinjeon@kernel.org, sj1557.seo@samsung.com, yuezhang.mo@sony.com, almaz.alexandrovich@paragon-software.com, slava@dubeyko.com, glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu, adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org, pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com, trondmy@kernel.org, anna@kernel.org, jaegeuk@kernel.org, chao@kernel.org, hansg@kernel.org, senozhatsky@chromium.org, Chuck Lever , Roland Mainz X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=2621; i=chuck.lever@oracle.com; h=from:subject:message-id; bh=yr1QdNRA2c3h2NX2KtSKVIgsso0huI4pF/+aMWQ1VYs=; b=owEBbQKS/ZANAwAKATNqszNvZn+XAcsmYgBp/FL1Sam2U6J6T59urOY+86EqRZVFFjEoduGtM uf7IC1GQ72JAjMEAAEKAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCafxS9QAKCRAzarMzb2Z/ l5GyEACg2sRkHeSvck4ZjxMkPio+UqMmRR5OiaW9/jiwt59VHMhPD6sENsxwjXhcbRCFnj82KrO 2jqV/aesyDWk6k6VqQa+RA5CCZFYh8fhMrCD+dSzO7MmuTK+qtU5dd6iuSsFBh/yS+WmT9nATMl x/kMmQk+pYp7XIc7uGMjSQiedqk59+P1JJx/fS1UBZDnj12YJDrCVeeQMFbCHwvH05l0AaFpNOR mN46wI6rx9s9DPdie38+NNRopiHB7wraDHnNvu0655Hky1P+VlPxOI02wPLKdwgkyDaqY3lunUM h7e6AF+3is/p1mrEzY8YISbb3Cx+80MVTlHACehQGEqwB9oPGnOdG14tWrg5i/7wvQooLl/PG/F 6YVNvk6K0ACFmYCi2yLajipMA3ybQhCe69V7YoHGtD1hAK+W5pjdjbcIY8fjgKAt/5ILxCR6hjx O9Trom0rs4ZlEmdgoKPS31REkntgOGMmaqxNvB8NL/jhQvEhpGHYxgTPl8gf+3G9ZzzqJem6QjF HzKVQbMBOV58d2OrPKmRKYaDGZTnlc8DXXYpDmIgub4d8946l/U9i5iQvnaKGGE63izZXXxbdYa mLx8jx5/imR1h/R6jUKv2iZfwMtzOJ0sLPD1i9IuhmICRuT3eQaj9QrrZqLvVmOZbuOgVJBanBz ppoitklVcRCApaA== X-Developer-Key: i=chuck.lever@oracle.com; a=openpgp; fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97 From: Chuck Lever Add case sensitivity reporting to the existing hfsplus_fileattr_get() function via the FS_XFLAG_CASEFOLD flag. HFS+ always preserves case at rest. Case sensitivity depends on how the volume was formatted: HFSX volumes may be either case-sensitive or case-insensitive, indicated by the HFSPLUS_SB_CASEFOLD superblock flag. FS_XFLAG_CASEFOLD is read-only: FS_XFLAG_RDONLY_MASK ensures FS_IOC_FSSETXATTR strips it. The legacy FS_IOC_SETFLAGS path in hfsplus_fileattr_set() also allows FS_CASEFOLD_FL through its allowlist on case-insensitive volumes so that a chattr read-modify-write cycle does not fail with EOPNOTSUPP. Reviewed-by: Viacheslav Dubeyko Reviewed-by: Roland Mainz Signed-off-by: Chuck Lever --- fs/hfsplus/inode.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c index d05891ec492e..5565c14b4bf6 100644 --- a/fs/hfsplus/inode.c +++ b/fs/hfsplus/inode.c @@ -740,6 +740,7 @@ int hfsplus_fileattr_get(struct dentry *dentry, struct file_kattr *fa) { struct inode *inode = d_inode(dentry); struct hfsplus_inode_info *hip = HFSPLUS_I(inode); + struct hfsplus_sb_info *sbi = HFSPLUS_SB(inode->i_sb); unsigned int flags = 0; if (inode->i_flags & S_IMMUTABLE) @@ -748,6 +749,8 @@ int hfsplus_fileattr_get(struct dentry *dentry, struct file_kattr *fa) flags |= FS_APPEND_FL; if (hip->userflags & HFSPLUS_FLG_NODUMP) flags |= FS_NODUMP_FL; + if (test_bit(HFSPLUS_SB_CASEFOLD, &sbi->flags)) + flags |= FS_CASEFOLD_FL; fileattr_fill_flags(fa, flags); @@ -759,13 +762,24 @@ int hfsplus_fileattr_set(struct mnt_idmap *idmap, { struct inode *inode = d_inode(dentry); struct hfsplus_inode_info *hip = HFSPLUS_I(inode); + struct hfsplus_sb_info *sbi = HFSPLUS_SB(inode->i_sb); + unsigned int allowed = FS_IMMUTABLE_FL | FS_APPEND_FL | FS_NODUMP_FL; unsigned int new_fl = 0; if (fileattr_has_fsx(fa)) return -EOPNOTSUPP; + /* + * FS_CASEFOLD_FL reflects HFSPLUS_SB_CASEFOLD, a mount-time + * property. Accept it as a no-op so chattr's RMW round-trip + * succeeds; reject any attempt to enable it on a volume that + * was not formatted case-insensitive. + */ + if (test_bit(HFSPLUS_SB_CASEFOLD, &sbi->flags)) + allowed |= FS_CASEFOLD_FL; + /* don't silently ignore unsupported ext2 flags */ - if (fa->flags & ~(FS_IMMUTABLE_FL|FS_APPEND_FL|FS_NODUMP_FL)) + if (fa->flags & ~allowed) return -EOPNOTSUPP; if (fa->flags & FS_IMMUTABLE_FL) -- 2.53.0