Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Christian Brauner <brauner@kernel.org>,
	David Howells <dhowells@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Steve French <sfrench@samba.org>,
	linux-cifs@vger.kernel.org, Paulo Alcantara <pc@manguebit.org>
Subject: Re: [GIT PULL for v7.1] vfs fixes
Date: Mon, 18 May 2026 12:46:22 -0700	[thread overview]
Message-ID: <20260518194622.GA2914683@ax162> (raw)
In-Reply-To: <20260518-vfs-7.1-rc5.fixes-3eded3a501f4@brauner>

On Mon, May 18, 2026 at 09:35:59AM +0200, Christian Brauner wrote:
> David Howells (22):
>       netfs: Fix potential for tearing in ->remote_i_size and ->zero_point
...
>  fs/smb/client/cifsfs.c       |  38 ++++--

The changes in this file from that patch breaks the build with clang:

  fs/smb/client/cifsfs.c:1390:29: error: variable 'old_size' is uninitialized when used here [-Werror,-Wuninitialized]
   1390 |                 if (rc == 0 && new_size > old_size) {
        |                                           ^~~~~~~~
  fs/smb/client/cifsfs.c:1307:37: note: initialize the variable 'old_size' to silence this warning
   1307 |         unsigned long long i_size, old_size, new_size, zero_point;
        |                                            ^
        |                                             = 0
  fs/smb/client/cifsfs.c:1375:13: error: variable 'zero_point' is uninitialized when used here [-Werror,-Wuninitialized]
   1375 |         if (fend > zero_point)
        |                    ^~~~~~~~~~
  fs/smb/client/cifsfs.c:1307:59: note: initialize the variable 'zero_point' to silence this warning
   1307 |         unsigned long long i_size, old_size, new_size, zero_point;
        |                                                                  ^
        |                                                                   = 0
  2 errors generated.

There were no -next updates last week, so it seems like the majority of
this pull request saw zero -next testing time. I see two kbuild test
robot build reports but I guess they were ignored.

  https://lore.kernel.org/202605031459.eX5UbO3K-lkp@intel.com/
  https://lore.kernel.org/202605021450.ca5QGqLH-lkp@intel.com/

-- 
Cheers,
Nathan

       reply	other threads:[~2026-05-18 19:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260518-vfs-7.1-rc5.fixes-3eded3a501f4@brauner>
2026-05-18 19:46 ` Nathan Chancellor [this message]
2026-05-18 21:05   ` [GIT PULL for v7.1] vfs fixes David Howells
2026-05-18 21:32     ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260518194622.GA2914683@ax162 \
    --to=nathan@kernel.org \
    --cc=brauner@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pc@manguebit.org \
    --cc=sfrench@samba.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox