Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-cifs@vger.kernel.org,
	samba-technical@lists.samba.org,
	Steve French <stfrench@microsoft.com>,
	Roland Mainz <roland.mainz@nrubsig.org>
Subject: [cifs:for-next-next 15/16] fs/smb/client/cifsfs.c:1204:43: error: 'FS_XFLAG_CASEFOLD' undeclared
Date: Fri, 05 Jun 2026 09:25:36 +0200	[thread overview]
Message-ID: <202606050946.OIt0UXdo-lkp@intel.com> (raw)

tree:   git://git.samba.org/sfrench/cifs-2.6.git for-next-next
head:   910f40bbf5dc81b5fcc5592fdd4caa29e80ffce0
commit: 4fb53948f97f5e89700fa933ba7d928ba1980f06 [15/16] cifs: Implement fileattr_get for case sensitivity
config: x86_64-rhel-9.4-ltp (https://download.01.org/0day-ci/archive/20260605/202606050946.OIt0UXdo-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260605/202606050946.OIt0UXdo-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606050946.OIt0UXdo-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/smb/client/cifsfs.c: In function 'cifs_fileattr_get':
>> fs/smb/client/cifsfs.c:1204:43: error: 'FS_XFLAG_CASEFOLD' undeclared (first use in this function)
    1204 |                         fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
         |                                           ^~~~~~~~~~~~~~~~~
   fs/smb/client/cifsfs.c:1204:43: note: each undeclared identifier is reported only once for each function it appears in
>> fs/smb/client/cifsfs.c:1215:35: error: 'FS_XFLAG_CASENONPRESERVING' undeclared (first use in this function)
    1215 |                 fa->fsx_xflags |= FS_XFLAG_CASENONPRESERVING;
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/FS_XFLAG_CASEFOLD +1204 fs/smb/client/cifsfs.c

  1168	
  1169	int cifs_fileattr_get(struct dentry *dentry, struct file_kattr *fa)
  1170	{
  1171		struct cifs_sb_info *cifs_sb = CIFS_SB(dentry->d_sb);
  1172		struct cifs_tcon *tcon = cifs_sb_master_tcon(cifs_sb);
  1173		struct inode *inode = d_inode(dentry);
  1174		u32 attrs;
  1175	
  1176		/* Preserve FS_COMPR_FL previously reported by cifs_ioctl(). */
  1177		if (CIFS_I(inode)->cifsAttrs & ATTR_COMPRESSED)
  1178			fa->flags |= FS_COMPR_FL;
  1179	
  1180		/*
  1181		 * FS_CASEFOLD_FL is defined by UAPI as a folder attribute,
  1182		 * and userspace tools (e.g., lsattr) display it only on
  1183		 * directories. Confine the case-handling bits to directories
  1184		 * to match that convention; for non-directories the share's
  1185		 * case semantics are still discoverable through the parent.
  1186		 */
  1187		if (!S_ISDIR(inode->i_mode))
  1188			return 0;
  1189	
  1190		/*
  1191		 * The server's FS_ATTRIBUTE_INFORMATION response, cached on
  1192		 * the tcon at mount, reflects the share's case-handling
  1193		 * semantics after any POSIX extensions negotiation. Prefer
  1194		 * it over the client-local nocase mount option, which only
  1195		 * governs dentry comparison on this superblock.
  1196		 *
  1197		 * QueryFSInfo is best-effort at mount; when it did not
  1198		 * populate fsAttrInfo, MaxPathNameComponentLength remains
  1199		 * zero. In that case fall back to nocase so the reporting
  1200		 * matches the comparison behavior installed on the sb.
  1201		 */
  1202		if (le32_to_cpu(tcon->fsAttrInfo.MaxPathNameComponentLength) == 0) {
  1203			if (tcon->nocase) {
> 1204				fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
  1205				fa->flags |= FS_CASEFOLD_FL;
  1206			}
  1207			return 0;
  1208		}
  1209		attrs = le32_to_cpu(tcon->fsAttrInfo.Attributes);
  1210		if (!(attrs & FILE_CASE_SENSITIVE_SEARCH)) {
  1211			fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
  1212			fa->flags |= FS_CASEFOLD_FL;
  1213		}
  1214		if (!(attrs & FILE_CASE_PRESERVED_NAMES))
> 1215			fa->fsx_xflags |= FS_XFLAG_CASENONPRESERVING;
  1216		return 0;
  1217	}
  1218	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-06-05  7:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202606050946.OIt0UXdo-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=roland.mainz@nrubsig.org \
    --cc=samba-technical@lists.samba.org \
    --cc=stfrench@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox