From: ChenXiaoSong <chenxiaosong@chenxiaosong.com>
To: smfrench@gmail.com, linkinjeon@kernel.org, pc@manguebit.org,
ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com,
bharathsm@microsoft.com, senozhatsky@chromium.org,
dhowells@redhat.com, metze@samba.org, gael.blivet@gmail.com
Cc: linux-cifs@vger.kernel.org, ChenXiaoSong <chenxiaosong@kylinos.cn>
Subject: [RFC PATCH 06/11] smb/server: save simple notify events
Date: Thu, 23 Jul 2026 03:16:34 +0000 [thread overview]
Message-ID: <20260723031644.312866-7-chenxiaosong@chenxiaosong.com> (raw)
In-Reply-To: <20260723031644.312866-1-chenxiaosong@chenxiaosong.com>
From: ChenXiaoSong <chenxiaosong@kylinos.cn>
Save create, delete, and change events.
Example:
1. client: smbinfo notify /mnt
2. server: ksmbd.control --debug=notify
3. server: touch /export/file
server debug log:
ksmbd: Queueing notify event, action 1, name file
ksmbd: Queueing notify event, action 3, name file
4. server: rm /export/file
server debug log:
ksmbd: Queueing notify event, action 2, name file
Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
---
fs/smb/server/notify.c | 106 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 106 insertions(+)
diff --git a/fs/smb/server/notify.c b/fs/smb/server/notify.c
index 82de53963dc0..a873625555ea 100644
--- a/fs/smb/server/notify.c
+++ b/fs/smb/server/notify.c
@@ -9,6 +9,7 @@
*/
#include <linux/fsnotify_backend.h>
+#include <linux/ktime.h>
#include <linux/slab.h>
#include <linux/wait.h>
@@ -26,12 +27,22 @@ struct ksmbd_notify_mark {
struct ksmbd_notify *notify;
};
+struct ksmbd_notify_event {
+ struct list_head list;
+ u32 action;
+ u64 when;
+ size_t name_len;
+ char name[];
+};
+
struct ksmbd_notify {
struct fsnotify_group *group;
struct fsnotify_mark *mark;
struct ksmbd_file *fp;
/* Protects filter, rename state and the queued events. */
spinlock_t lock;
+ struct list_head events;
+ unsigned int num_events;
u32 filter;
u32 mask;
u32 max_buffer_size;
@@ -43,6 +54,8 @@ struct ksmbd_notify_req {
#define KSMBD_NOTIFY_NAME_EVENT_MASK (FS_CREATE | FS_DELETE | \
FS_MOVED_FROM | FS_MOVED_TO)
+#define KSMBD_NOTIFY_EVENT_MASK (FS_ATTRIB | FS_MODIFY | \
+ KSMBD_NOTIFY_NAME_EVENT_MASK)
static const struct {
u32 notify_mask;
@@ -77,6 +90,34 @@ static u32 ksmbd_notify_map(u32 filter)
return mask;
}
+static void ksmbd_notify_free_events(struct list_head *events)
+{
+ struct ksmbd_notify_event *event, *tmp;
+
+ list_for_each_entry_safe(event, tmp, events, list) {
+ list_del(&event->list);
+ kfree(event);
+ }
+}
+
+static bool ksmbd_notify_filter_match(struct ksmbd_notify *notify, u32 mask)
+{
+ u32 filter, notify_mask;
+
+ spin_lock(¬ify->lock);
+ filter = notify->filter;
+ notify_mask = notify->mask;
+ spin_unlock(¬ify->lock);
+
+ if (mask & KSMBD_NOTIFY_NAME_EVENT_MASK) {
+ if (mask & FS_ISDIR)
+ return filter & FILE_NOTIFY_CHANGE_DIR_NAME;
+ return filter & FILE_NOTIFY_CHANGE_FILE_NAME;
+ }
+
+ return mask & notify_mask;
+}
+
static void smb2_notify_cancel(void **argv)
{
struct ksmbd_notify_req *notify_req = argv[0];
@@ -85,6 +126,44 @@ static void smb2_notify_cancel(void **argv)
wake_up(¬ify_req->wait);
}
+static struct ksmbd_notify_event *
+ksmbd_notify_alloc_event(u32 action, const struct qstr *file_name, gfp_t gfp)
+{
+ struct ksmbd_notify_event *event;
+ size_t name_len = file_name ? file_name->len : 0;
+
+ event = kmalloc(sizeof(*event) + name_len + 1, gfp);
+ if (!event) {
+ pr_err("Failed to allocate notify event, action %u, name %.*s\n",
+ action, file_name ? file_name->len : 0,
+ file_name ? (const char *)file_name->name : "");
+ return NULL;
+ }
+
+ INIT_LIST_HEAD(&event->list);
+ event->action = action;
+ event->when = ktime_get_ns();
+ event->name_len = name_len;
+ if (name_len)
+ memcpy(event->name, file_name->name, name_len);
+ event->name[name_len] = '\0';
+
+ return event;
+}
+
+static void
+ksmbd_notify_queue_event(struct ksmbd_notify *notify,
+ struct ksmbd_notify_event *event)
+{
+ ksmbd_debug(NOTIFY, "Queueing notify event, action %u, name %s\n",
+ event->action, event->name);
+
+ spin_lock(¬ify->lock);
+ list_add_tail(&event->list, ¬ify->events);
+ notify->num_events++;
+ spin_unlock(¬ify->lock);
+}
+
static int ksmbd_notify_handle_inode_event(struct fsnotify_mark *mark,
u32 mask, struct inode *inode,
struct inode *dir,
@@ -92,9 +171,11 @@ static int ksmbd_notify_handle_inode_event(struct fsnotify_mark *mark,
u32 cookie)
{
struct ksmbd_notify_mark *notify_mark;
+ struct ksmbd_notify_event *event;
struct ksmbd_notify *notify;
struct inode *event_inode = dir ?: inode;
struct ksmbd_file *fp;
+ u32 action;
notify_mark = container_of(mark, struct ksmbd_notify_mark, mark);
notify = notify_mark->notify;
@@ -107,6 +188,29 @@ static int ksmbd_notify_handle_inode_event(struct fsnotify_mark *mark,
file_name ? file_name->len : 0,
file_name ? (const char *)file_name->name : "", cookie);
+ if (!(mask & KSMBD_NOTIFY_EVENT_MASK)) {
+ ksmbd_debug(NOTIFY, "Ignored notify event mask 0x%x\n", mask);
+ return 0;
+ }
+
+ if (mask & FS_CREATE) {
+ action = FILE_ACTION_ADDED;
+ } else if (mask & FS_DELETE) {
+ action = FILE_ACTION_REMOVED;
+ } else {
+ action = FILE_ACTION_MODIFIED;
+ }
+
+ if (!ksmbd_notify_filter_match(notify, mask))
+ return 0;
+
+ event = ksmbd_notify_alloc_event(action, file_name,
+ KSMBD_DEFAULT_GFP);
+ if (!event)
+ return 0;
+
+ ksmbd_notify_queue_event(notify, event);
+
return 0;
}
@@ -206,6 +310,7 @@ static int ksmbd_notify_add(struct ksmbd_file *fp, u32 mask, u32 filter,
notify->fp = fp;
spin_lock_init(¬ify->lock);
+ INIT_LIST_HEAD(¬ify->events);
notify->filter = filter;
notify->mask = mask;
notify->max_buffer_size = max_buffer_size;
@@ -254,6 +359,7 @@ void ksmbd_notify_remove(struct ksmbd_file *fp)
(unsigned long long)file_inode(fp->filp)->i_ino,
notify->mark->mask);
ksmbd_notify_destroy_mark(notify->group, notify->mark);
+ ksmbd_notify_free_events(¬ify->events);
kfree(notify);
}
--
2.54.0
next prev parent reply other threads:[~2026-07-23 3:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 3:16 [RFC PATCH 00/11] smb/server: change notify support ChenXiaoSong
2026-07-23 3:16 ` [RFC PATCH 01/11] smb/server: add debug type for change notify ChenXiaoSong
2026-07-23 3:16 ` [RFC PATCH 02/11] smb/server: validate notify requests ChenXiaoSong
2026-07-25 13:31 ` Namjae Jeon
2026-07-23 3:16 ` [RFC PATCH 03/11] smb/server: support canceling " ChenXiaoSong
2026-07-23 3:16 ` [RFC PATCH 04/11] smb/server: watch directories for changes ChenXiaoSong
2026-07-25 13:44 ` Namjae Jeon
2026-07-23 3:16 ` [RFC PATCH 05/11] smb/server: keep notify watches on file handles ChenXiaoSong
2026-07-25 13:51 ` Namjae Jeon
2026-07-23 3:16 ` ChenXiaoSong [this message]
2026-07-23 3:16 ` [RFC PATCH 07/11] smb/server: save old names for rename notify events ChenXiaoSong
2026-07-23 3:16 ` [RFC PATCH 08/11] smb/server: match " ChenXiaoSong
2026-07-23 3:16 ` [RFC PATCH 09/11] smb/server: encode " ChenXiaoSong
2026-07-23 3:16 ` [RFC PATCH 10/11] smb/server: send notify events to the client ChenXiaoSong
2026-07-25 13:58 ` Namjae Jeon
2026-07-25 14:02 ` Namjae Jeon
2026-07-25 14:14 ` ChenXiaoSong
2026-07-23 3:16 ` [RFC PATCH 11/11] smb/server: break directory leases before sending notify events ChenXiaoSong
2026-07-24 13:35 ` [RFC PATCH 00/11] smb/server: change notify support ChenXiaoSong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723031644.312866-7-chenxiaosong@chenxiaosong.com \
--to=chenxiaosong@chenxiaosong.com \
--cc=bharathsm@microsoft.com \
--cc=chenxiaosong@kylinos.cn \
--cc=dhowells@redhat.com \
--cc=gael.blivet@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=metze@samba.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox