From: Frank Sorenson <sorenson@redhat.com>
To: linux-cifs@vger.kernel.org, stfrench@microsoft.com, pc@manguebit.org
Subject: [PATCH v2 0/3] cifs: three size-management bug fixes
Date: Thu, 6 Aug 2026 21:41:55 -0500 [thread overview]
Message-ID: <20260807024158.3707995-1-sorenson@redhat.com> (raw)
These patches fix three independent bugs in cifs file size and handle
management.
Patch 1 fixes a use-after-free in cifs_file_set_size(): when the
handle-based set_file_size() call fails and falls through to the
path-based fallback, tcon is reused from the cifsFileInfo that was
already released by cifsFileInfo_put(). If that put drops the last
reference on a tlink that has been removed from the tlink tree, the
subsequent set_path_size() call is a use-after-free.
Patch 2 fixes a premature i_size update in cifs_do_truncate(): when
no cached writable handle is available, the server truncation happens
implicitly via the O_TRUNC flag in the following cifs_open() request,
but the current code sets i_size to 0 locally beforehand. If the
subsequent open fails, other processes sharing the inode observe a
spuriously zero-sized file.
Patch 3 fixes a loff_t underflow in cifs_remap_file_range() when
len == 0 and off >= i_size. The computed length is negative, which
corrupts downstream arithmetic and sends a huge ByteCount in the
FSCTL_DUPLICATE_EXTENTS_TO_FILE request.
Patches 1 and 2 fix regressions introduced by commit 110fee6b9bb5
("smb: client: fix missing timestamp updates with O_TRUNC").
v2: rebased
Frank Sorenson (3):
cifs: clear tcon after cifsFileInfo_put() in cifs_file_set_size()
cifs: don't update i_size in cifs_do_truncate() without a cached
handle
cifs: fix loff_t underflow in cifs_remap_file_range() when len == 0
fs/smb/client/cifsfs.c | 7 ++++++-
fs/smb/client/file.c | 17 +++++++++++++----
fs/smb/client/inode.c | 1 +
3 files changed, 20 insertions(+), 5 deletions(-)
--
2.55.0
next reply other threads:[~2026-08-07 2:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 2:41 Frank Sorenson [this message]
2026-08-07 2:41 ` [PATCH v2 1/3] cifs: clear tcon after cifsFileInfo_put() in cifs_file_set_size() Frank Sorenson
2026-08-07 2:41 ` [PATCH v2 2/3] cifs: don't update i_size in cifs_do_truncate() without a cached handle Frank Sorenson
2026-08-07 2:41 ` [PATCH v2 3/3] cifs: fix loff_t underflow in cifs_remap_file_range() when len == 0 Frank Sorenson
2026-08-07 11:06 ` [PATCH v2 0/3] cifs: three size-management bug fixes Frank Sorenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807024158.3707995-1-sorenson@redhat.com \
--to=sorenson@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=stfrench@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox