From: Dairui Zhang <zhangdairui@gmail.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: linux-cifs@vger.kernel.org, smfrench@gmail.com,
senozhatsky@chromium.org, tom@talpey.com, pc@manguebit.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ksmbd: rework ksmbd_validate_name_reconnect() to use a dentry walk
Date: Sun, 4 Oct 2026 23:11:04 +0800 [thread overview]
Message-ID: <20261004151104.2196869-1-zhangdairui@gmail.com> (raw)
In-Reply-To: <20260930001605.1917523-1-zhangdairui@gmail.com>
Namjae,
Thanks for the patches. I went through both and they look
correct, including the failure-path refcounting. My patch was
not good - it was too complicated. Yours is simpler and just
as effective.
One corner case: if the share root is unlinked between
kern_path() and d_path() at init, real_path can end up with a
" (deleted)" suffix, and a later cross-share fp at that
literal path would pass the prefix check.
prev parent reply other threads:[~2026-10-04 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 6:33 [PATCH] ksmbd: fix OOB read in ksmbd_validate_name_reconnect() Dairui Zhang
2026-09-28 4:54 ` Namjae Jeon
2026-09-28 5:20 ` [PATCH v2] ksmbd: fix OOB read and cross-share confusion " Dairui Zhang
2026-09-28 14:55 ` Namjae Jeon
2026-09-30 0:16 ` [PATCH] ksmbd: rework ksmbd_validate_name_reconnect() to use a dentry walk Dairui Zhang
2026-10-04 1:23 ` Namjae Jeon
2026-10-04 15:11 ` Dairui Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261004151104.2196869-1-zhangdairui@gmail.com \
--to=zhangdairui@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox