From: David Howells <dhowells@redhat.com>
To: Stefan Metzmacher <metze@samba.org>
Cc: dhowells@redhat.com, smfrench@gmail.com, tom@talpey.com,
Long Li <longli@microsoft.com>,
Namjae Jeon <linkinjeon@kernel.org>,
linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: Fix problem with encrypted RDMA data read
Date: Wed, 16 Nov 2022 07:00:19 +0000 [thread overview]
Message-ID: <2147870.1668582019@warthog.procyon.org.uk> (raw)
In-Reply-To: <3609b064-175c-fc18-cd1a-e177d0349c58@samba.org>
Stefan Metzmacher <metze@samba.org> wrote:
> I'm not sure I understand why this would fix anything when encryption is
> enabled.
>
> Is the payload still be offloaded as plaintext? Otherwise we wouldn't have
> use_rdma_mr... So this rather looks like a fix for the non encrypted case.
The "inline"[*] PDUs are encrypted, but the direct RDMA data transmission is
not. I'm not sure if this is a bug in ksmbd. As I understand it, encrypting
and decrypting the directly transferred data would need to be done by the NIC,
not the cifs driver.
David
[*] I don't know the correct RDMA terminology for these things.
next prev parent reply other threads:[~2022-11-16 7:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 22:44 [PATCH] cifs: Fix problem with encrypted RDMA data read David Howells
2022-11-16 0:57 ` Stefan Metzmacher
2022-11-16 5:19 ` Namjae Jeon
2022-11-16 8:36 ` Stefan Metzmacher
2022-11-16 15:41 ` Tom Talpey
2022-11-16 15:44 ` Stefan Metzmacher
2022-11-16 16:14 ` Tom Talpey
2022-11-16 19:53 ` Stefan Metzmacher
2022-11-16 21:21 ` Tom Talpey
2022-11-16 16:44 ` David Howells
2022-11-16 7:00 ` David Howells [this message]
2022-11-16 9:05 ` Stefan Metzmacher
2022-11-16 12:14 ` David Howells
2022-11-16 12:53 ` Stefan Metzmacher
2022-11-16 13:09 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2147870.1668582019@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=metze@samba.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox