From: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vivien Didelot
<vivien.didelot-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
Subject: Re: [PATCH net-next 1/2] net: break include loop netdevice.h, dsa.h, devlink.h
Date: Tue, 28 Mar 2017 15:04:30 -0700 [thread overview]
Message-ID: <224a8890-5eaa-34cf-107b-70718a9c37e5@gmail.com> (raw)
In-Reply-To: <1490737507-7864-2-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
On 03/28/2017 02:45 PM, Andrew Lunn wrote:
> There is an include loop between netdevice.h, dsa.h, devlink.h because
> of NETDEV_ALIGN, making it impossible to use devlink structures in
> dsa.h.
>
> Break this loop by taking dsa.h out of netdevice.h, add a forward
> declaration of dsa_switch_tree and netdev_set_default_ethtool_ops()
> function, which is what netdevice.h requires.
>
> No longer having dsa.h in netdevice.h means the includes in dsa.h no
> longer get included. This breaks a few other files which depend on
> these includes. Add these directly in the affected file.
>
> Signed-off-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Woah, thanks for doing this!
Reviewed-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
--
Florian
next prev parent reply other threads:[~2017-03-28 22:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 21:45 [PATCH net-next 0/2] break include loop and dsa devlink support Andrew Lunn
[not found] ` <1490737507-7864-1-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2017-03-28 21:45 ` [PATCH net-next 1/2] net: break include loop netdevice.h, dsa.h, devlink.h Andrew Lunn
[not found] ` <1490737507-7864-2-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2017-03-28 22:04 ` Florian Fainelli [this message]
2017-03-29 5:46 ` [PATCH net-next 0/2] break include loop and dsa devlink support David Miller
2017-03-28 21:45 ` [PATCH net-next 2/2] net: dsa: dsa2: Add basic support of devlink Andrew Lunn
2017-03-29 0:33 ` Florian Fainelli
[not found] ` <2fe7ffc9-1bf1-537a-e361-33156a6f5a07-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-29 1:31 ` Andrew Lunn
2017-03-29 17:29 ` Florian Fainelli
[not found] ` <c844a885-cfd3-4358-89dd-c619d3d394e4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-29 17:36 ` Andrew Lunn
2017-03-30 6:17 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=224a8890-5eaa-34cf-107b-70718a9c37e5@gmail.com \
--to=f.fainelli-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=andrew-g2DYL2Zd6BY@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=vivien.didelot-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox