From: David Howells <dhowells@redhat.com>
To: =?utf-8?Q?Aur=C3=A9lien?= Aptel <aaptel@suse.com>
Cc: dhowells@redhat.com, Steve French <smfrench@gmail.com>,
CIFS <linux-cifs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] cifs: use discard iterator to discard unneeded network data more efficiently
Date: Sun, 07 Feb 2021 09:57:51 +0000 [thread overview]
Message-ID: <2689081.1612691871@warthog.procyon.org.uk> (raw)
In-Reply-To: <87eehwnn2c.fsf@suse.com>
Aurélien Aptel <aaptel@suse.com> wrote:
> > +{
> > + struct msghdr smb_msg;
> > +
> > + iov_iter_discard(&smb_msg.msg_iter, READ, to_read);
> > +
> > + return cifs_readv_from_socket(server, &smb_msg);
> > +}
> > +
>
> Shouldn't smb_msg be initialized to zeroes? Looking around this needs to
> be done for cifs_read_from_socket() and cifs_read_page_from_socket() too.
Yeah - I think you're right. I didn't manage to finish making the changes,
so what I gave to Steve wasn't tested.
David
next prev parent reply other threads:[~2021-02-07 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 6:25 [PATCH] cifs: use discard iterator to discard unneeded network data more efficiently Steve French
2021-02-04 10:29 ` Aurélien Aptel
2021-02-07 9:57 ` David Howells [this message]
2021-02-25 19:29 ` Steve French
2021-02-25 19:43 ` Steve French
2021-02-25 21:01 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2689081.1612691871@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox