From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED80AC4332F for ; Wed, 16 Nov 2022 12:20:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238559AbiKPMUR (ORCPT ); Wed, 16 Nov 2022 07:20:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233536AbiKPMTN (ORCPT ); Wed, 16 Nov 2022 07:19:13 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB2AC17E3F for ; Wed, 16 Nov 2022 04:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668600901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M5xy5cnF/duk7VrcsTyDcdzn9i/3nmmpMTSFAVYO+a0=; b=UVKsbtUaqbyrojbRiRQvxU43D/k2/xhlbFmWnIMwEZLR0OzlPkLW3Rbe0FWZXrwES025jc PIpbNgPsH0KMNEtz26fZVi5gJP8w3Qnvqqlm12uNxdQA3RmJIAu87mAans10KomxMX8qJd /rDmetp59tEBNnqRZy5Rw9aXGY27LxQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-563-Di9W9ovmOXC8d3Aj66WJ7Q-1; Wed, 16 Nov 2022 07:14:56 -0500 X-MC-Unique: Di9W9ovmOXC8d3Aj66WJ7Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 09E9D2999B45; Wed, 16 Nov 2022 12:14:56 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id D40E12166B29; Wed, 16 Nov 2022 12:14:54 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <88b441af-d6ae-4d46-aae5-0b649e76031d@samba.org> References: <88b441af-d6ae-4d46-aae5-0b649e76031d@samba.org> <3609b064-175c-fc18-cd1a-e177d0349c58@samba.org> <166855224228.1998592.2212551359609792175.stgit@warthog.procyon.org.uk> <2147870.1668582019@warthog.procyon.org.uk> To: Stefan Metzmacher Cc: dhowells@redhat.com, smfrench@gmail.com, tom@talpey.com, Long Li , Namjae Jeon , linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cifs: Fix problem with encrypted RDMA data read MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2780585.1668600891.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 16 Nov 2022 12:14:51 +0000 Message-ID: <2780586.1668600891@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Stefan Metzmacher wrote: > > Stefan Metzmacher wrote: > > = > >> I'm not sure I understand why this would fix anything when encryption= is > >> enabled. > >> > >> Is the payload still be offloaded as plaintext? Otherwise we wouldn't= have > >> use_rdma_mr... So this rather looks like a fix for the non encrypted= case. > > The "inline"[*] PDUs are encrypted, but the direct RDMA data transmiss= ion is > > not. I'm not sure if this is a bug in ksmbd. > = > It's a bug in the client! Well, if you can fix it the right way, I can test the patch. I'm not sure what that would be if not what I suggested. David