Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Tom Talpey <tom@talpey.com>
Cc: dhowells@redhat.com, Steve French <sfrench@samba.org>,
	Shyam Prasad N <nspmangalore@gmail.com>,
	Rohith Surabattula <rohiths.msft@gmail.com>,
	Long Li <longli@microsoft.com>,
	Namjae Jeon <linkinjeon@kernel.org>,
	Stefan Metzmacher <metze@samba.org>,
	Jeff Layton <jlayton@kernel.org>,
	linux-cifs@vger.kernel.org
Subject: Re: [PATCH] cifs: Fix oops due to uncleared server->smbd_conn in reconnect
Date: Thu, 26 Jan 2023 15:20:23 +0000	[thread overview]
Message-ID: <2861100.1674746423@warthog.procyon.org.uk> (raw)
In-Reply-To: <0d4d0b2f-bb2b-a69b-2009-8c883119c10d@talpey.com>

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

Tom Talpey <tom@talpey.com> wrote:

> Do you have any logging from the softRoCE runs? I'd suspect some
> kind of RDMA-specific scatter/gather overflow which might be
> server-side as easily as client-side.
> 
> On client, try:
>   echo 0x1ff >/sys/module/cifs/parameters/smbd_logging_class
> 
> On server:
>    ksmbd.control -d conn
>    ksmbd.control -d rdma

Okay, on -rc5 without my patches, using:

# rdma link add rxe0 type rxe netdev enp6s0 # andromeda, softRoCE
# mount //192.168.6.1/test /xfstest.test -o user=shares,pass=foobar,rdma
# dd if=/dev/zero of=/xfstest.test/hello2 bs=16k count=1 oflag=direct conv=notrunc seek=2

the dd hangs.  I've captured the client and server logging you requested plus
a pcap file on the server (see attached).

Note also I tried md5summing a 1MiB file and that produced a different MD5 sum
each time.  I couldn't see enough data being transferred in the pcap to
indicate that that was happening.

David


[-- Attachment #2: Client dmesg log --]
[-- Type: application/gzip, Size: 7196 bytes --]

[-- Attachment #3: Server dmesg log --]
[-- Type: application/gzip, Size: 4350 bytes --]

[-- Attachment #4: Server packet capture --]
[-- Type: application/gzip, Size: 9728 bytes --]

  reply	other threads:[~2023-01-26 15:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24 17:48 cifs-rdma: KASAN-detected UAF when using rxe driver David Howells
2023-01-25  7:48 ` David Howells
2023-01-25 14:02 ` [PATCH] cifs: Fix oops due to uncleared server->smbd_conn in reconnect David Howells
2023-01-25 14:47   ` Tom Talpey
2023-01-26 15:20     ` David Howells [this message]
2023-01-26 19:22       ` Tom Talpey
2023-01-26 19:49         ` David Howells
2023-01-25 15:52   ` Tom Talpey
2023-01-25 20:41     ` David Howells
2023-01-25 22:24       ` Tom Talpey
2023-01-25 22:43         ` David Howells
2023-01-25 22:56           ` Tom Talpey
2023-01-26 14:42             ` pcap of misbehaving fallocate over cifs rdma David Howells
     [not found]               ` <CAH2r5mupuFEw4hY7uOYjeHi08pS9vv3n30KppR_CTrKZ4xAdnw@mail.gmail.com>
2023-01-26 19:54                 ` David Howells
2023-01-26 20:29                   ` Tom Talpey
2023-01-26 20:47                     ` David Howells
2023-01-25 23:42           ` [PATCH] cifs: Fix oops due to uncleared server->smbd_conn in reconnect Namjae Jeon
2023-01-25 16:20   ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2861100.1674746423@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=jlayton@kernel.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=metze@samba.org \
    --cc=nspmangalore@gmail.com \
    --cc=rohiths.msft@gmail.com \
    --cc=sfrench@samba.org \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox