From: Paulo Alcantara <pc@manguebit.com>
To: Steve French <smfrench@gmail.com>
Cc: Shyam Prasad N <nspmangalore@gmail.com>,
Bharath SM <bharathsm.hsk@gmail.com>,
linux-cifs@vger.kernel.org, David Howells <dhowells@redhat.com>,
Pierguido Lambri <plambri@redhat.com>,
Bharath S M <bharathsm@microsoft.com>
Subject: Re: [PATCH] smb: client: fix delay on concurrent opens
Date: Mon, 12 May 2025 19:57:51 -0300 [thread overview]
Message-ID: <2f71b485b8a733acf11c5de66e68438c@manguebit.com> (raw)
In-Reply-To: <CAH2r5mtmcFWw6Gm4hg9Ze_1VnN-t4d5LSmEh+oObKASWNXbatw@mail.gmail.com>
Steve French <smfrench@gmail.com> writes:
> On Mon, May 12, 2025 at 8:31 AM Paulo Alcantara <pc@manguebit.com> wrote:
>>
>> Shyam Prasad N <nspmangalore@gmail.com> writes:
>>
>> > I think this version of the patch will be more problematic, as it will
>> > open up a time window between the lease break ack and the file close.
>> > Which is why we moved the _cifsFileInfo_put above as it is today.
>>
>> Can you explain why it would be a problem sending a lease break ack
>> and then closing the file?
>
> It is a performance issue to send an extra roundtrip that is unneeded, so
> key question is why was the close not sent immediately if it was
> a deferred close case.
Agreed. Even worse when the saved roundtrip causes concurrent opens to
be delayed by 30s.
Look at the commands I shared. The close is sent immediately after the
lease break is received by the client.
prev parent reply other threads:[~2025-05-12 22:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 14:05 [PATCH] smb: client: fix delay on concurrent opens Paulo Alcantara
2025-04-28 14:40 ` Steve French
2025-04-28 14:44 ` Paulo Alcantara
2025-04-30 14:15 ` Steve French
2025-04-30 19:14 ` Paulo Alcantara
[not found] ` <CAH2r5mu74CbSKRVi0P7LD57j3t=KxqLX_M6V+qvi-aRE2t9YTw@mail.gmail.com>
2025-04-30 19:44 ` Paulo Alcantara
2025-05-05 10:41 ` Bharath SM
2025-05-05 13:12 ` Paulo Alcantara
2025-05-05 14:16 ` Bharath SM
2025-05-05 15:05 ` Paulo Alcantara
2025-05-09 11:22 ` Shyam Prasad N
2025-05-12 13:31 ` Paulo Alcantara
2025-05-12 22:47 ` Steve French
2025-05-12 22:57 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f71b485b8a733acf11c5de66e68438c@manguebit.com \
--to=pc@manguebit.com \
--cc=bharathsm.hsk@gmail.com \
--cc=bharathsm@microsoft.com \
--cc=dhowells@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=plambri@redhat.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox