Re: [PATCH] smb: client: fix delay on concurrent opens

[Paulo Alcantara <pc@manguebit.com>]

Steve French <smfrench@gmail.com> writes:

> Did you mean
>
> downgraded "RWH to RW"  or downgraded from "RWH to RH"

Downgraded from RWH to RW.

> But it is puzzling why file would still be open if not in openfile list

The server is breaking the H lease.  cifs_close_deferred_file() will put
all cifsFileInfo references from deferred closes in the inode, meaning
that _cifsFileInfo_put() call in cifs_oplock_break() will effectively
put the last reference and then closing the open handle.

The check for a non-empty list after that makes no sense as we already
closed all open handles.  As I understand it, the implicit ACK would
work if we have no open handles at the time we receive the lease break,
but that couldn't work as we always get an active reference of the open
handle before processing the lease break.

What am I missing?