From: David Howells <dhowells@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: dhowells@redhat.com, smfrench@gmail.com, viro@zeniv.linux.org.uk,
nspmangalore@gmail.com, rohiths.msft@gmail.com, tom@talpey.com,
metze@samba.org, hch@infradead.org, willy@infradead.org,
jlayton@kernel.org, linux-cifs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
sfrench@samba.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 05/12] cifs: Add a function to Hash the contents of an iterator
Date: Wed, 01 Feb 2023 14:36:43 +0000 [thread overview]
Message-ID: <312908.1675262203@warthog.procyon.org.uk> (raw)
In-Reply-To: <Y9ooW52m0Afnhj7Z@gondor.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > Add a function to push the contents of a BVEC-, KVEC- or XARRAY-type
> > iterator into a symmetric hash algorithm.
>
> There is no such thing as a symmetric hash. You're using shash
> which stands for synchronous hash.
Sorry, you're right.
> In any case, as I said in the previous review this is abusing the
> shash API. Please use ahash instead.
It's already abusing the shash API, this doesn't change that, except where it
gets the data from.
I can have a go at conversion to ahash, but that will have to be a separate
patch set as it isn't trivial. The problem is that the current code just
assumes it can push bits into the hash as it gets them - this is not possible
with ahash.
David
next prev parent reply other threads:[~2023-02-01 14:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 18:28 [PATCH 00/12] smb3: Use iov_iters down to the network transport and fix DIO page pinning David Howells
2023-01-31 18:28 ` [PATCH 01/12] netfs: Add a function to extract a UBUF or IOVEC into a BVEC iterator David Howells
2023-01-31 18:28 ` [PATCH 02/12] netfs: Add a function to extract an iterator into a scatterlist David Howells
2023-01-31 18:28 ` [PATCH 03/12] cifs: Implement splice_read to pass down ITER_BVEC not ITER_PIPE David Howells
2023-02-01 13:35 ` Christoph Hellwig
2023-01-31 18:28 ` [PATCH 04/12] cifs: Add a function to build an RDMA SGE list from an iterator David Howells
2023-01-31 18:28 ` [PATCH 05/12] cifs: Add a function to Hash the contents of " David Howells
2023-02-01 8:52 ` Herbert Xu
2023-02-01 14:36 ` David Howells [this message]
2023-02-02 0:55 ` Herbert Xu
2023-02-03 21:00 ` David Howells
2023-01-31 18:28 ` [PATCH 06/12] cifs: Add some helper functions David Howells
2023-01-31 18:28 ` [PATCH 07/12] cifs: Add a function to read into an iter from a socket David Howells
2023-01-31 18:28 ` [PATCH 09/12] cifs: Build the RDMA SGE list directly from an iterator David Howells
2023-01-31 18:28 ` [PATCH 10/12] cifs: Remove unused code David Howells
2023-01-31 18:28 ` [PATCH 11/12] cifs: Fix problem with encrypted RDMA data read David Howells
2023-02-01 13:36 ` Christoph Hellwig
2023-02-01 14:00 ` Stefan Metzmacher
2023-02-01 14:05 ` Stefan Metzmacher
2023-02-01 14:52 ` Stefan Metzmacher
2023-01-31 18:28 ` [PATCH 12/12] cifs: DIO to/from KVEC-type iterators should now work David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=312908.1675262203@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metze@samba.org \
--cc=nspmangalore@gmail.com \
--cc=rohiths.msft@gmail.com \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox