From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25898ECAAA1 for ; Thu, 27 Oct 2022 13:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234721AbiJ0NG1 (ORCPT ); Thu, 27 Oct 2022 09:06:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234988AbiJ0NGZ (ORCPT ); Thu, 27 Oct 2022 09:06:25 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 794F558E9A for ; Thu, 27 Oct 2022 06:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666875983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h3esAL34hsd7fi8HYNIYP56t4S/yycCKV0wPq2bO/WI=; b=ThFU82VSu8OEcxGbfwq0+BWo17POFCaEjjovtpPRu3PFyhy3fMHfv3LosBP9jO+XFWk9g3 TrMfCpe65ObuuF/5BgrOmva+GQAPfBQ745Y5fTKCMlLgbbA8rGLX2VCEqi044PkGRemZcq ZI6+k5z/yAp/hIGGFjDG/MJjE5NffK4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-673-AEZKjTL8P1mUcLgflbbgGQ-1; Thu, 27 Oct 2022 09:06:22 -0400 X-MC-Unique: AEZKjTL8P1mUcLgflbbgGQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A6D95800B30; Thu, 27 Oct 2022 13:06:20 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.73]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A9D32024CB7; Thu, 27 Oct 2022 13:06:19 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20221027083547.46933-9-jefflexu@linux.alibaba.com> References: <20221027083547.46933-9-jefflexu@linux.alibaba.com> <20221027083547.46933-1-jefflexu@linux.alibaba.com> To: Jingbo Xu Cc: dhowells@redhat.com, jlayton@kernel.org, linux-cachefs@redhat.com, linux-erofs@lists.ozlabs.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/9] fscache,netfs: move PageFsCache() family helpers to fscache.h MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3306288.1666875978.1@warthog.procyon.org.uk> Date: Thu, 27 Oct 2022 14:06:18 +0100 Message-ID: <3306289.1666875978@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Jingbo Xu wrote: > Besides, it's also quite reasonable to move these helpers to fscache.h > given their names. They're going to go away. Please don't use them at all unless you must. Just leave them where they are. David