From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE30FA3745 for ; Thu, 27 Oct 2022 13:12:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236050AbiJ0NMi (ORCPT ); Thu, 27 Oct 2022 09:12:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236055AbiJ0NME (ORCPT ); Thu, 27 Oct 2022 09:12:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70723792E9 for ; Thu, 27 Oct 2022 06:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666876292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=08qQCOq6HXtPu07yJoUG1gykaILDIdfjGgF17Vne+y0=; b=bu8B6ZXMaWJisHIi1UFeVLTHXKzcJY8jKOIzh9iLso0lcI9g9da2zfnfba7KEfo1cWW0dw Gh5nzeHdD/zDO0OEeZ460Q3Oyp2QbRaLggqv6wzWJ3k2eEkCudCODDt3s0Sc23oHKiERzI 6cOT77fLgohgAB4m3p9Ap95jMzdpKpw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-649-YAG-GrF1PNKY9HcojBWvQA-1; Thu, 27 Oct 2022 09:11:26 -0400 X-MC-Unique: YAG-GrF1PNKY9HcojBWvQA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8D41E811E75; Thu, 27 Oct 2022 13:11:25 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.73]) by smtp.corp.redhat.com (Postfix) with ESMTP id 66BC01121333; Thu, 27 Oct 2022 13:11:24 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20221027083547.46933-8-jefflexu@linux.alibaba.com> References: <20221027083547.46933-8-jefflexu@linux.alibaba.com> <20221027083547.46933-1-jefflexu@linux.alibaba.com> To: Jingbo Xu Cc: dhowells@redhat.com, jlayton@kernel.org, linux-cachefs@redhat.com, linux-erofs@lists.ozlabs.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/9] fscache,netfs: define flags for prepare_read() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3306594.1666876283.1@warthog.procyon.org.uk> Date: Thu, 27 Oct 2022 14:11:23 +0100 Message-ID: <3306595.1666876283@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Jingbo Xu wrote: > + if (test_bit(FSCACHE_REQ_COPY_TO_CACHE, &flags)) > + __set_bit(NETFS_SREQ_COPY_TO_CACHE, &subreq->flags); Please don't do that in netfslib. Netfslib shouldn't know about fscache's inner workings. David