From: Paulo Alcantara <pc@manguebit.org>
To: Henrique Carvalho <henrique.carvalho@suse.com>
Cc: smfrench@gmail.com, Thiago Becker <tbecker@redhat.com>,
David Howells <dhowells@redhat.com>,
linux-cifs@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] smb: client: fix oops due to uninitialised var in smb2_unlink()
Date: Fri, 06 Mar 2026 19:51:44 -0300 [thread overview]
Message-ID: <353be345dcf906816d61e127583032d2@manguebit.org> (raw)
In-Reply-To: <r7ojhnxu3jkr42oczp2o5w3hp5bs24ft5yav6nnlcohsybqeuv@zjvwndvvxayc>
Henrique Carvalho <henrique.carvalho@suse.com> writes:
> Reviewed-by: Henrique Carvalho <henrique.carvalho@suse.com>
>
> We got a lot of those replay uninitialised bugs. Maybe we should prevent
> them by having a replay(func, cond) so we can take advantage of a clean
> stack. Opinions?
Agreed. No strong opinions. I'm wondering if that should be
implemented in the transport layer, therefore we could get rid of all
that duplicate code. Alternatively, having the thing implemented in
netfslib instead.
next prev parent reply other threads:[~2026-03-06 22:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 0:57 [PATCH] smb: client: fix oops due to uninitialised var in smb2_unlink() Paulo Alcantara
2026-03-06 19:33 ` Henrique Carvalho
2026-03-06 22:51 ` Paulo Alcantara [this message]
2026-03-11 18:05 ` Henrique Carvalho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=353be345dcf906816d61e127583032d2@manguebit.org \
--to=pc@manguebit.org \
--cc=dhowells@redhat.com \
--cc=henrique.carvalho@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tbecker@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox