From: David Howells <dhowells@redhat.com>
To: Steve French <smfrench@gmail.com>
Cc: dhowells@redhat.com, liujian56@huawei.com,
ZhangXiaoxu <zhangxiaoxu5@huawei.com>,
CIFS <linux-cifs@vger.kernel.org>
Subject: Re: Fwd: [PATCH] cifs: use kfree in error path of cifs_writedata_alloc()
Date: Thu, 10 Nov 2022 22:13:58 +0000 [thread overview]
Message-ID: <3802821.1668118438@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAH2r5ms6p4_PdihrLC+ZJ4W=YjqOmwYhDT-fF6swZ5SB0fP4Ww@mail.gmail.com>
Steve French <smfrench@gmail.com> wrote:
> 'pages' is allocated by kcalloc(), which should freed by kfree().
Either kfree() or kvfree() will do; though kfree() is going to be slightly
faster.
David
prev parent reply other threads:[~2022-11-10 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 11:19 [PATCH] cifs: use kfree in error path of cifs_writedata_alloc() Liu Jian
2022-11-10 20:30 ` Fwd: " Steve French
2022-11-10 22:13 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3802821.1668118438@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=liujian56@huawei.com \
--cc=smfrench@gmail.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox