From: Paulo Alcantara <pc@manguebit.com>
To: Steve French <smfrench@gmail.com>
Cc: linux-cifs@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 3/3] smb: client: handle max length for SMB symlinks
Date: Mon, 18 Nov 2024 15:59:20 -0300 [thread overview]
Message-ID: <3d10dd5c3a7f190533474e4ec48f07e4@manguebit.com> (raw)
In-Reply-To: <CAH2r5mueythTtWNcgaduN1=CW3gt+xQc2mY=naYEn_mmKY2vMg@mail.gmail.com>
Steve French <smfrench@gmail.com> writes:
> Presumably a symlink could be up to PATH_MAX (4096), is there any
> reason not to fix the client side to be able to handle at least 4096?
Even if we fix client to handle larger responses, Windows Server will
not allow more than 4091 characters due to MS-FSA 2.1.5.10.37. It's
even worst with encryption that we only support parsing large responses
with SMB2_READ.
Yes, we could fix the client to support up to 4091 chars, but that is
out of scope for this series. This patch is for allowing users to
create SMB symlinks and read them back with and without encryption.
prev parent reply other threads:[~2024-11-18 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 15:35 [PATCH 1/3] smb: client: improve compound padding in encryption Paulo Alcantara
2024-11-18 15:35 ` [PATCH 2/3] smb: client: get rid of bounds check in SMB2_ioctl_init() Paulo Alcantara
2024-11-18 15:35 ` [PATCH 3/3] smb: client: handle max length for SMB symlinks Paulo Alcantara
2024-11-18 17:08 ` Steve French
2024-11-18 18:59 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d10dd5c3a7f190533474e4ec48f07e4@manguebit.com \
--to=pc@manguebit.com \
--cc=dhowells@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox