From: Ralph Boehme <slow@samba.org>
To: Volker Lendecke <vl@samba.org>, linux-cifs@vger.kernel.org
Subject: Re: [PATCH 0/7] Avoid a few casts from void *
Date: Mon, 27 Mar 2023 16:56:54 +0200 [thread overview]
Message-ID: <3df3fce7-bf62-b0ec-6125-54f118b0e97d@samba.org> (raw)
In-Reply-To: <cover.1679051552.git.vl@samba.org>
[-- Attachment #1.1: Type: text/plain, Size: 722 bytes --]
On 3/17/23 12:15, Volker Lendecke wrote:
> We should not go through void * without type-checking if it's not
> really necessary.
>
> Volker Lendecke (7):
> cifs: Avoid a cast in add_lease_context()
> cifs: Avoid a cast in add_durable_context()
> cifs: Avoid a cast in add_posix_context()
> cifs: Avoid a cast in add_sd_context()
> cifs: Avoid a cast in add_durable_v2_context()
> cifs: Avoid a cast in add_durable_reconnect_v2_context()
> cifs: Avoid a cast in add_query_id_context()
>
> fs/cifs/smb2pdu.c | 55 ++++++++++++++++++++++++++---------------------
> 1 file changed, 30 insertions(+), 25 deletions(-)
>
Reviewed-by Ralph Boehme <slow@samba.org>
Thanks!
-slow
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2023-03-27 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 11:15 [PATCH 0/7] Avoid a few casts from void * Volker Lendecke
2023-03-17 11:15 ` [PATCH 1/7] cifs: Avoid a cast in add_lease_context() Volker Lendecke
2023-03-17 11:15 ` [PATCH 2/7] cifs: Avoid a cast in add_durable_context() Volker Lendecke
2023-03-17 11:15 ` [PATCH 3/7] cifs: Avoid a cast in add_posix_context() Volker Lendecke
2023-03-17 11:15 ` [PATCH 4/7] cifs: Avoid a cast in add_sd_context() Volker Lendecke
2023-03-17 11:15 ` [PATCH 5/7] cifs: Avoid a cast in add_durable_v2_context() Volker Lendecke
2023-03-17 11:15 ` [PATCH 6/7] cifs: Avoid a cast in add_durable_reconnect_v2_context() Volker Lendecke
2023-03-17 11:15 ` [PATCH 7/7] cifs: Avoid a cast in add_query_id_context() Volker Lendecke
2023-03-27 14:56 ` Ralph Boehme [this message]
2023-04-24 2:22 ` [PATCH 0/7] Avoid a few casts from void * Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3df3fce7-bf62-b0ec-6125-54f118b0e97d@samba.org \
--to=slow@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=vl@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox