From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B812C433F5 for ; Thu, 10 Mar 2022 01:40:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233862AbiCJBl3 (ORCPT ); Wed, 9 Mar 2022 20:41:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232929AbiCJBl2 (ORCPT ); Wed, 9 Mar 2022 20:41:28 -0500 Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBEF79BAE6; Wed, 9 Mar 2022 17:40:27 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R261e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0V6m1KrN_1646876422; Received: from 30.225.24.63(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0V6m1KrN_1646876422) by smtp.aliyun-inc.com(127.0.0.1); Thu, 10 Mar 2022 09:40:23 +0800 Message-ID: <3e942459-bb15-6322-10ae-dbadb09dd72c@linux.alibaba.com> Date: Thu, 10 Mar 2022 09:40:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 01/19] fscache: export fscache_end_operation() Content-Language: en-US To: Jeff Layton , David Howells , linux-cachefs@redhat.com Cc: Anna Schumaker , Steve French , Dominique Martinet , David Wysochanski , Ilya Dryomov , Linus Torvalds , linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <164678185692.1200972.597611902374126174.stgit@warthog.procyon.org.uk> <164678190346.1200972.7453733431978569479.stgit@warthog.procyon.org.uk> <9132b97b5e52fec9c2838b31739175619df3e752.camel@kernel.org> From: JeffleXu In-Reply-To: <9132b97b5e52fec9c2838b31739175619df3e752.camel@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On 3/9/22 11:26 PM, Jeff Layton wrote: > On Tue, 2022-03-08 at 23:25 +0000, David Howells wrote: >> From: Jeffle Xu >> >> Export fscache_end_operation() to avoid code duplication. >> >> Besides, considering the paired fscache_begin_read_operation() is >> already exported, it shall make sense to also export >> fscache_end_operation(). >> > > Not what I think of when you say "exporting" but the patch itself looks > fine. > Yes, maybe "fscache: make fscache_end_operation() generally available" as David said shall be better... -- Thanks, Jeffle