Re: [PATCH] cifs: show 'soft' in the mount options for !hard mounts

[Leif Sahlberg <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

NFS does the same, well except for the fact that 'hard' is default in that land.

NFS:
Mount with 'hard'  : mount shows ',hard'
Mount with 'soft'  : mount shows ',soft'
Mount with default : mount shows ',hard'



----- Original Message -----
From: "Steve French" <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Ronnie Sahlberg" <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "linux-cifs" <linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Sent: Wednesday, 20 September, 2017 1:25:52 PM
Subject: Re: [PATCH] cifs: show 'soft' in the mount options for !hard mounts

What does NFS do - does it show both "soft" and "hard"?

On Tue, Sep 19, 2017 at 10:22 PM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Opinions on stable?
>
> On Sep 19, 2017 8:09 PM, "Ronnie Sahlberg" <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>>
>> Signed-off-by: Ronnie Sahlberg <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>>  fs/cifs/cifsfs.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
>> index 180b3356ff86..a864e6575309 100644
>> --- a/fs/cifs/cifsfs.c
>> +++ b/fs/cifs/cifsfs.c
>> @@ -461,6 +461,8 @@ cifs_show_options(struct seq_file *s, struct dentry
>> *root)
>>                 seq_puts(s, ",nocase");
>>         if (tcon->retry)
>>                 seq_puts(s, ",hard");
>> +       else
>> +               seq_puts(s, ",soft");
>>         if (tcon->use_persistent)
>>                 seq_puts(s, ",persistenthandles");
>>         else if (tcon->use_resilient)
>> --
>> 2.13.3
>>
>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html