From: Markus Elfring <Markus.Elfring@web.de>
To: chenxiaosong@kylinos.cn, linux-cifs@vger.kernel.org,
Namjae Jeon <linkinjeon@kernel.org>,
Namjae Jeon <linkinjeon@samba.org>,
Steve French <sfrench@samba.org>,
Steve French <smfrench@gmail.com>
Cc: chenxiaosong.chenxiaosong@linux.dev, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/6] smb/server: fix return values of smb2_0_server_cmds proc
Date: Sat, 18 Oct 2025 20:42:16 +0200 [thread overview]
Message-ID: <441b1b8f-5fcf-4908-aadc-2fc16f559fb0@web.de> (raw)
In-Reply-To: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev>
> These functions should return error code when an error occurs,
> then __process_request() will print the error messages.
You propose to correct some questionable implementation details.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc1#n605
Regards,
Markus
next prev parent reply other threads:[~2025-10-18 18:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 10:46 [PATCH v2 0/6] smb/server: fix return values of smb2_0_server_cmds proc chenxiaosong.chenxiaosong
2025-10-17 10:46 ` [PATCH v2 1/6] smb/server: fix return value of smb2_read() chenxiaosong.chenxiaosong
2025-10-18 18:27 ` Markus Elfring
[not found] ` <CAH2r5mt4X4+k89t9CSqxuF55jooOt=X-BMB9AGR+e9WNEh6Y0g@mail.gmail.com>
[not found] ` <cc22c66e-9ecb-4aa4-9b38-bd148820269c@web.de>
[not found] ` <CAH2r5mtiAy7h__rFd9mP-jutx38C9JSpPOPhn9ngqsezeX4_4g@mail.gmail.com>
[not found] ` <8d9ab96f-b7cf-4ebb-9a1b-4b0f2b94461f@web.de>
[not found] ` <CAH2r5mvx5+zQwhFRz-_dMmxYDX4PDzY5X9WGEd0M1Xf73bRyLA@mail.gmail.com>
[not found] ` <3d3fe6c0-b05e-4e36-8b02-0fc16438c781@linux.dev>
2025-10-19 11:56 ` [v2 " ChenXiaoSong
2025-10-19 12:32 ` Markus Elfring
2025-10-17 10:46 ` [PATCH v2 2/6] smb/server: fix return value of smb2_notify() chenxiaosong.chenxiaosong
2025-10-18 18:30 ` Markus Elfring
2025-11-11 9:54 ` ChenXiaoSong
2025-10-17 10:46 ` [PATCH v2 3/6] smb/server: fix return value of smb2_query_dir() chenxiaosong.chenxiaosong
2025-10-17 10:46 ` [PATCH v2 4/6] smb/server: fix return value of smb2_ioctl() chenxiaosong.chenxiaosong
2025-10-17 10:46 ` [PATCH v2 5/6] smb/server: fix return value of smb2_oplock_break() chenxiaosong.chenxiaosong
2025-10-17 10:46 ` [PATCH v2 6/6] smb/server: update some misguided comment of smb2_0_server_cmds proc chenxiaosong.chenxiaosong
2025-10-17 14:55 ` [PATCH v2 0/6] smb/server: fix return values " ChenXiaoSong
2025-10-18 1:14 ` Namjae Jeon
2025-10-18 18:42 ` Markus Elfring [this message]
2025-11-10 3:01 ` ChenXiaoSong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441b1b8f-5fcf-4908-aadc-2fc16f559fb0@web.de \
--to=markus.elfring@web.de \
--cc=chenxiaosong.chenxiaosong@linux.dev \
--cc=chenxiaosong@kylinos.cn \
--cc=linkinjeon@kernel.org \
--cc=linkinjeon@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox