Re: [PATCH 5/8] cifs: implement CIFSCheckMFSymlink()

["Stefan (metze) Metzmacher" <metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

Am 05.08.2010 14:44, schrieb Suresh Jayaraman:
> On 08/04/2010 07:41 PM, Stefan Metzmacher wrote:
>> Signed-off-by: Stefan Metzmacher <metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
>> ---
>>  fs/cifs/link.c |   65 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 files changed, 65 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/cifs/link.c b/fs/cifs/link.c
>> index 0d90a89..6cd0879 100644
>> --- a/fs/cifs/link.c
>> +++ b/fs/cifs/link.c
>> @@ -114,6 +114,71 @@ CIFSCheckMFSymlink(struct cifs_fattr *fattr,
>>  		   const unsigned char *path,
>>  		   struct cifs_sb_info *cifs_sb, int xid)
>>  {
>> +	int rc;
>> +	int oplock = 0;
>> +	__u16 netfid = 0;
>> +	struct cifsTconInfo *pTcon = cifs_sb->tcon;
>> +	u8 *buf;
>> +	char *pbuf;
>> +	unsigned int bytes_read = 0;
>> +	int buf_type = CIFS_NO_BUFFER;
>> +	unsigned int link_len = 0;
>> +	FILE_ALL_INFO file_info;
>> +
>> +	if (!(fattr->cf_mode & S_IFREG))
>> +		/* it's not a symlink */
>> +		return 0;
> 
> Perhaps a little naive - what if cf_mode is S_IFDIR?

Then it's a directory and not a symlink.

metze


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]