Re: Source code of SMB2 Kernel module

[Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>]

On 11/10/2010 01:18 PM, Shinnosuke Yagi wrote:
> 
> I added some logging messages.
> 
> # git diff fs/smb2/smb2fs.c
> diff --git a/fs/smb2/smb2fs.c b/fs/smb2/smb2fs.c
> index aa550a3..52c9f35 100644
> --- a/fs/smb2/smb2fs.c
> +++ b/fs/smb2/smb2fs.c
> @@ -57,7 +57,7 @@ static struct quotactl_ops smb2_quotactl_ops;
> 
>  /* Definitions of various global variables follow */
> 
> -int smb2FYI;
> +int smb2FYI = 1;
>  int smb2ERROR = 1;
>  int trace_SMB2;
> 
> I got following logs on dmesg.
> ====================================================
> FS-Cache: Netfs 'smb2' registered for caching
> fs/smb2/smb2fs.c: SMB2_max_buf_size 0x4000
> fs/smb2/smb2fs.c: smb2_init_request_bufs 0
> fs/smb2/smb2fs.c: register_filesystem 0
> fs/smb2/smb2fs.c: register_key_type -17

-17 is -EEXIST which means ket type with the name is already present.
The below patch should fix the problem I think. Could you try and
report back?


From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
Subject: [PATCH] smb2: rename smb2 spnego key type

.. to avoid key registration failure. register_key_type() doesn't allow key
types with same names.

Reported-by: Shinnosuke Yagi <yagi.shinnosuke-o7dWnD6vFTHqq2nvvmkE/A@public.gmane.org>
Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
---
 fs/smb2/smb2_spnego.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/smb2/smb2_spnego.c b/fs/smb2/smb2_spnego.c
index 6551002..24df95a 100644
--- a/fs/smb2/smb2_spnego.c
+++ b/fs/smb2/smb2_spnego.c
@@ -61,7 +61,7 @@ smb2_spnego_key_destroy(struct key *key)
  * keytype for SMB2 spnego keys
  */
 struct key_type smb2_spnego_key_type = {
-	.name		= "cifs.spnego",
+	.name		= "smb2.spnego",
 	.instantiate	= smb2_spnego_key_instantiate,
 	.match		= user_match,
 	.destroy	= smb2_spnego_key_destroy,