Re: [PATCH 2/4] cifs: move "ntlmssp" and "local_leases" options out of experimental code

[Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>]

On 12/08/2010 08:33 PM, Jeff Layton wrote:
> I see no real need to leave these sorts of options under an
> EXPERIMENTAL ifdef. Since you need a mount option to turn this code
> on, that only blows out the testing matrix.
> 
> local_leases has been under the EXPERIMENTAL tag for some time, but
> it's only the mount option that's under this label. Move it out
> from under this tag.
> 
> The NTLMSSP code is also under EXPERIMENTAL, but it needs a mount
> option to turn it on, and in the future any distro will reasonably
> want this enabled. Go ahead and move it out from under the
> EXPERIMENTAL tag.
> 
> Signed-off-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  fs/cifs/cifssmb.c |    5 +--
>  fs/cifs/connect.c |    4 --
>  fs/cifs/sess.c    |  103 ++++++++++++++++++++++++-----------------------------
>  3 files changed, 48 insertions(+), 64 deletions(-)

Moving local_leases out sounds fine to me. While I agree that NTLMSSP is
something everyone wants moving ahead, I'm not sure whether there are
currently any known/open issues with specific Servers.
Shirish?

Assuming there are none,

Acked-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>