From: Ben Greear <greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org>
To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Repeatable crash in 2.6.38 related to O_DIRECT
Date: Tue, 05 Apr 2011 16:34:17 -0700 [thread overview]
Message-ID: <4D9BA6F9.1050207@candelatech.com> (raw)
In-Reply-To: <20110405162609.6776e264-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
On 04/05/2011 04:26 PM, Jeff Layton wrote:
> Does the attached patch fix it? It's probably stable material if so...
I'll test your patch. I verified that cifs_file is NULL in cifsFileInfo_put
and protecting against that also solves the problem.
>
> FWIW, cifs doesn't handle O_DIRECT at all.
I know..and I warn my users when the open() call fails, but I still
let them attempt the file open. Seems a decent test case after all :)
Thanks,
Ben
--
Ben Greear <greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2011-04-05 23:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 22:46 Repeatable crash in 2.6.38 related to O_DIRECT Ben Greear
[not found] ` <4D9B9BB0.3030604-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2011-04-05 23:26 ` Jeff Layton
[not found] ` <20110405162609.6776e264-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-04-05 23:33 ` Steve French
2011-04-05 23:34 ` Ben Greear [this message]
[not found] ` <4D9BA6F9.1050207-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2011-04-05 23:38 ` Jeff Layton
[not found] ` <20110405163802.778b55b3-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-04-05 23:48 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9BA6F9.1050207@candelatech.com \
--to=greearb-my8/4n5vti7c+919tysfda@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox