From: Suresh Jayaraman <sjayaraman-IBi9RG/b67k@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-cifs <linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Alexander Swen <alex-UE4+9DRHXtc@public.gmane.org>
Subject: [PATCH v2 2/3] cifs: warn about deprecation of /proc/fs/cifs/OplockEnabled interface
Date: Wed, 12 Oct 2011 11:51:53 +0530 [thread overview]
Message-ID: <4E953201.9060606@suse.com> (raw)
The plan is to deprecate this interface by kernel version 3.4.
Changes since v1
- add a '\n' to the printk.
Reported-by: Alexander Swen <alex-UE4+9DRHXtc@public.gmane.org>
Cc: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
---
fs/cifs/cifs_debug.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
index 2fe3cf1..831fe13 100644
--- a/fs/cifs/cifs_debug.c
+++ b/fs/cifs/cifs_debug.c
@@ -526,6 +526,9 @@ static ssize_t cifs_oplock_proc_write(struct file *file,
char c;
int rc;
+ printk(KERN_WARNING "CIFS: The /proc/fs/cifs/OplockEnabled interface "
+ "will be removed in kernel version 3.4. Please migrate to "
+ "using the 'enable_oplocks' module parameter in cifs.ko.\n");
rc = get_user(c, buffer);
if (rc)
return rc;
next reply other threads:[~2011-10-12 6:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 6:21 Suresh Jayaraman [this message]
[not found] ` <4E953201.9060606-IBi9RG/b67k@public.gmane.org>
2011-10-12 22:44 ` [PATCH v2 2/3] cifs: warn about deprecation of /proc/fs/cifs/OplockEnabled interface Steve French
[not found] ` <CAH2r5mub6MNsq84pCHb048KQJs8QQucUWARropbQ8nh5DgL=uQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-10-12 22:52 ` Steve French
[not found] ` <CAH2r5ms5QbKiwTzjTbNBrQgpe=E68jd6xhoNJ32kCdvp7UK+Kw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-10-13 4:48 ` Suresh Jayaraman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E953201.9060606@suse.com \
--to=sjayaraman-ibi9rg/b67k@public.gmane.org \
--cc=alex-UE4+9DRHXtc@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox