linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>, cocci@inria.fr
Cc: linux-cifs@vger.kernel.org
Subject: Re: [cocci] Improving source code parsing for “fs/smb/client/dir.c”?
Date: Mon, 13 Oct 2025 15:05:21 +0200	[thread overview]
Message-ID: <4a37e90c-f008-4094-91db-7e284e974a5b@web.de> (raw)
In-Reply-To: <805f36f6-ea15-cbc9-f510-45856eb6f6d7@inria.fr>

> If you want the problem to be solved, please make some effort to narrow it
> down to a smaller number of lines. …

Can other data parsing technology help more here?

Why are the following source file parts marked as “bad” so far?

1. Complete implementation of the function “cifs_do_create”

2. Comment line between two function implementations

3. Blank lines

4. Closing curly bracket from the function “check_name”


Regards,
Markus

  parent reply	other threads:[~2025-10-13 13:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13 11:50 Improving source code parsing for “fs/smb/client/dir.c”? Markus Elfring
2025-10-13 12:04 ` [cocci] " Julia Lawall
2025-10-13 12:16   ` Markus Elfring
2025-10-13 13:05   ` Markus Elfring [this message]
2025-10-13 14:35   ` Markus Elfring
2025-10-13 14:49     ` Julia Lawall
2025-10-13 15:00       ` Markus Elfring
2025-10-13 15:47       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a37e90c-f008-4094-91db-7e284e974a5b@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@inria.fr \
    --cc=julia.lawall@inria.fr \
    --cc=linux-cifs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).