Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Paulo Alcantara <pc@manguebit.com>
To: Adam Williamson <awilliam@redhat.com>, Steve French <smfrench@gmail.com>
Cc: linux-cifs@vger.kernel.org
Subject: Re: [PATCH] smb: client: fix regression with guest option
Date: Wed, 12 Mar 2025 13:02:43 -0300	[thread overview]
Message-ID: <4cbaab94c2ba97a8d91b9f43ea8a3662@manguebit.com> (raw)
In-Reply-To: <70d0157ac13725595d64978b11c4d3a91f417803.camel@redhat.com>

Adam Williamson <awilliam@redhat.com> writes:

> On Wed, 2025-03-12 at 10:32 -0500, Steve French wrote:
>> merged into cifs-2.6.git for-next pending additional testing/review
>> 
>> Presumably we could also update cifs-utils (mount.cifs.c) to
>> workaround this as well.  Thoughts?
>
> Yeah, I was going to ask whether just not passing password2 when doing
> anonymous mount might be an option? That way the new cifs-utils will
> work with older kernels, rather than being a sudden surprise for anyone
> who happens to get a new cifs-utils but not a new kernel, for whatever

Yes, we could also change cifs-utils to not send both password= and
password2= when using guest mount option.

The kernel change is still required in case someone is using mount(2)
directly and end up passing an empty password2= option.

  reply	other threads:[~2025-03-12 16:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12 13:51 [PATCH] smb: client: fix regression with guest option Paulo Alcantara
2025-03-12 15:32 ` Steve French
2025-03-12 15:51   ` Adam Williamson
2025-03-12 16:02     ` Paulo Alcantara [this message]
2025-03-12 16:06       ` Steve French
2025-03-12 16:23         ` Paulo Alcantara
2025-03-15  7:09           ` Meetakshi Setiya
2025-03-17 12:46             ` Paulo Alcantara
2025-03-17 21:29             ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cbaab94c2ba97a8d91b9f43ea8a3662@manguebit.com \
    --to=pc@manguebit.com \
    --cc=awilliam@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox