From: Scott Lovenberg <scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
samba-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org
Subject: Re: [PATCH] Add warning that NFS syntax is deprecated and will be removed in cifs-utils-6.0.
Date: Thu, 18 Oct 2012 13:57:09 -0400 [thread overview]
Message-ID: <508042F5.1030203@gmail.com> (raw)
In-Reply-To: <1350582614-11930-2-git-send-email-scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 10/18/2012 1:50 PM, scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Scott Lovenberg<scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Signed-off-by: Scott Lovenberg<scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> mount.cifs.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/mount.cifs.c b/mount.cifs.c
> index 756fce2..061ce32 100644
> --- a/mount.cifs.c
> +++ b/mount.cifs.c
> @@ -1335,6 +1335,7 @@ static int parse_unc(const char *unc_name, struct parsed_mount_info *parsed_info
> }
>
> /* Set up "host" and "share" pointers based on UNC format. */
> + /* TODO: Remove support for NFS syntax as of cifs-utils-6.0. */
> if (strncmp(unc_name, "//", 2)&& strncmp(unc_name, "\\\\", 2)) {
> /*
> * check for nfs syntax (server:/share/prepath)
> @@ -1351,6 +1352,9 @@ static int parse_unc(const char *unc_name, struct parsed_mount_info *parsed_info
> share++;
> if (*share == '/')
> ++share;
> + fprintf(stderr, "WARNING: using NFS syntax for mounting CIFS "
> + "shares is deprecated and will be removed in cifs-utils"
> + "-6.0. Please migrate to UNC syntax.");
> } else {
> host = unc_name + 2;
> hostlen = strcspn(host, "/\\");
Sorry, git send-email just blew up in my face. It was supposed to send
a first email that explained the patch. Of course it worked perfectly
when I tested it to my own email address. I'll figure out why the first
message is missing and repost. Sorry for the noise.
next prev parent reply other threads:[~2012-10-18 17:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 17:50 CIFS: Deprecating NFS mounting syntax in mount.cifs scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <1350582614-11930-1-git-send-email-scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-18 17:50 ` [PATCH] Add warning that NFS syntax is deprecated and will be removed in cifs-utils-6.0 scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <1350582614-11930-2-git-send-email-scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-18 17:57 ` Scott Lovenberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-18 18:07 CIFS: Deprecating NFS mounting syntax in mount.cifs scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <1350583669-12118-1-git-send-email-scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-18 18:07 ` [PATCH] Add warning that NFS syntax is deprecated and will be removed in cifs-utils-6.0 scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <1350583669-12118-2-git-send-email-scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-23 19:40 ` Jeff Layton
2012-10-17 16:29 scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <1350491389-8895-1-git-send-email-scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-17 20:21 ` Jeff Layton
2012-10-17 21:05 ` Jeff Layton
[not found] ` <20121017170513.0e4075c4-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2012-10-18 3:45 ` Scott Lovenberg
[not found] ` <CAFB9KM0x4-Jj9Bvxd0RdzbKqTCS5ecYEmqYDOHmNjzbC8PqZPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-18 19:20 ` Scott Lovenberg
[not found] ` <50805666.1030705-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-18 19:22 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508042F5.1030203@gmail.com \
--to=scott.lovenberg-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
--cc=samba-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox