From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A54831422CB for ; Tue, 23 Apr 2024 21:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=44.202.169.39 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713907618; cv=none; b=XaZW3pLUBD7nXn8ZQFKQpkB2lsmfAwgEtUdoUzwB2SMmaI2yBmi12N0HZmesY7HFVv+MMYBR1GM8Cd2deUZCiqXKtnvtgzftDNIWdyd7gkIKvuQc09mNI3J1wFVBB9aQd+/ZaYNvMa5SgEYaqx7BhoS6k1iwPh+KykISOMi4Xos= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713907618; c=relaxed/simple; bh=AR4/jfl18d1BrNGvop+qwiaQnL9UlAgiNSZUFkUuPkA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m0wQGY2mQtUoyd24xjm0qhLV/jiHvzlXFqXEU7IeM3mAWNiLQCGrlOKemo4My/XrHyqZp+ZXld1R8ZCiHx+ziHCLh6dACpALY7gXBcdpRkpXFuZIDdGUzEcx5/IyDVvcpjxsSWTFhNvhFU9P91cLGcMFmLBFGejosKB+5D64LMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=l08TqcJ3; arc=none smtp.client-ip=44.202.169.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="l08TqcJ3" Received: from eig-obgw-5008a.ext.cloudfilter.net ([10.0.29.246]) by cmsmtp with ESMTPS id zITprqtpxl9dRzNfDrE3il; Tue, 23 Apr 2024 21:26:55 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id zNfDr3TCUU0uyzNfDrf2QS; Tue, 23 Apr 2024 21:26:55 +0000 X-Authority-Analysis: v=2.4 cv=VYTxPkp9 c=1 sm=1 tr=0 ts=6628279f a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=Sfg9OT4WXbNM99GaDXVDBA==:17 a=IkcTkHD0fZMA:10 a=raytVjVEu-sA:10 a=wYkD_t78qR0A:10 a=VdDABtCXyk9SiVsiCNMA:9 a=QEXdDO2ut3YA:10 a=QYH75iMubAgA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AwENOt2jGw9fqo5gAkt7vsoIvQip3Njh2Yjyg0AisJ8=; b=l08TqcJ3vWK9Wbr79qe0LKF9pk /UJRjVPioyW4djkhv7WQgP6YIOo/Uqi7x1GunjpStme8J2jG0ltsOeEIvwKwOvxsxtlmhTTVqLev0 93tqWOfrGtVNHzv5cLn+EZEXms//gISVtrYurCM5KiIfT4Rnvr3k4iBkJB+ehB9MQ4CivF0LTzZ/2 U0oYelpSUWSqvnED/SgmJZEAwrkec2xCuxT2Q0vjqvBFtI6IQx7Ochy8qFI9j1ogo0Zcwni/U3q+G 3StbiX5bHRxlg4WQKW4sKzZQm2VcCm9mOxxgIuNphMpO6GTk3hCtYimXYEpSR6v8u6X+E41+Cv1a9 qRYkP2tw==; Received: from [45.167.200.115] (port=1190 helo=[192.168.5.44]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1rzNfA-002j2b-2J; Tue, 23 Apr 2024 16:26:53 -0500 Message-ID: <509125aa-9f92-438c-9a18-2cf3400d7194@embeddedor.com> Date: Wed, 24 Apr 2024 07:26:30 +1000 Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][next] smb: smb2pdu.h: Avoid -Wflex-array-member-not-at-end warnings To: Steve French Cc: "Gustavo A. R. Silva" , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Namjae Jeon , Sergey Senozhatsky , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Kees Cook References: <1166494b-3e34-4919-9998-141540a948b3@embeddedor.com> <7789881d-a709-48f4-8c14-259acbce813a@embeddedor.com> Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 45.167.200.115 X-Source-L: No X-Exim-ID: 1rzNfA-002j2b-2J X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.5.44]) [45.167.200.115]:1190 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 20 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNZFPyq9vfY8zP9Max3MaA+wYODZurOJ7nrpuKasjNIndZI6b3mzfOIOPe4qrRosHvLYL/ribsz6z3bXkB1Bv9CG+hycxX1JEU6PsbTVETYeffDmd4Tf InlZf1mwlHwQfD348vvrJ1buIqMSUmtMacNqDEjaqGyKFRN3dDHBTinLl0GNrripOtYvEWLJlSlloJD8lBvi8AsPDFErBwbyg2H0ygVIezmghDjqvjxTjtrj >> The _packed in the commit 0268a7cc7fdc is not an attribute, it's the name >> for the group. So, it's not actually doing what the submitter thinks it does. > > Do you want to submit a followup fix to fix this? Or let Namjae fix it? > The fix is correct. I'm sorry, I confused the suffix `_attr` with `_tagged` in the struct_group() family of functions. I've been in airports the last 24 hours, and I my brain needs some rest. Thanks! -- Gustavo