From: Marcus Moeller <marcus.moeller-OI3hZJvNYWs@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
David McBride <dwm37-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Stefan (metze) Metzmacher"
<metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Subject: Re: [PATCH] cifs: don't instantiate new dentries in readdir for inodes that need to be revalidated immediately
Date: Mon, 12 Aug 2013 08:07:29 +0200 [thread overview]
Message-ID: <52087BA1.4020307@gmx.ch> (raw)
In-Reply-To: <CAH2r5muc+5xpabeQYNJq5Vb2_2nAMof2EUUFbkMpoBsUX7MC+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]
Am 08.08.2013 17:33, schrieb Steve French:
> On Thu, Aug 8, 2013 at 9:22 AM, Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>> On Thu, 08 Aug 2013 16:05:44 +0200
>> Marcus Moeller <marcus.moeller-OI3hZJvNYWs@public.gmane.org> wrote:
>>
>>> Am 07.08.2013 15:42, schrieb David McBride:
>>>> On 07/08/13 14:06, Jeff Layton wrote:
>>>>
>>>>> This patch is untested (other than for compilation), but I think it'll
>>>>> do the right thing. Metze, David could you test it and let us know if
>>>>> it helps?
>>>
>>> Just to verify: could it be that mfsymlink is already broken in
>>> 3.9.6-301.fc19? At least links created with fedora 18 are no longer
>>> readable there. Newly created links seems to work fine (at least till now).
>>>
>>> Greets
>>> Marcus
>>>
>>
>> Yes, 3.9.6 has the patch that broke it.
>>
>> What matters is how the (in memory) inode is created after mounting. If
>> you first run across an mfsymlink with a readdir() call, then you'll
>> get an inode that's "stuck" as a regular file. If you instead do
>> something like stat() it before ever running a readdir over the
>> containing directory, it should work just fine.
>>
>> This patch probably is probably reasonable for stable, given that the
>> original one also went there.
>>
>> Steve, want to mark as such?
@Jeff, could you please do me a favor and let me know, when this is
stable/made it to Fedora, as we are in need of that patch.
Thanks
Marcus
[-- Attachment #2: S/MIME Kryptografische Unterschrift --]
[-- Type: application/pkcs7-signature, Size: 2460 bytes --]
prev parent reply other threads:[~2013-08-12 6:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 15:36 [BUG] Regression in mfsymlink handling introduced by "cifs: only set ops for inodes in I_NEW state" David McBride
[not found] ` <51F92F0B.7030504-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2013-08-06 14:30 ` Stefan (metze) Metzmacher
[not found] ` <5201089C.1010403-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
2013-08-06 14:56 ` Jeff Layton
[not found] ` <20130806105623.322d32a6-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-08-07 12:09 ` Jeff Layton
2013-08-07 13:04 ` [PATCH] cifs: don't instantiate new dentries in readdir for inodes that need to be revalidated immediately Jeff Layton
[not found] ` <1375880647-22512-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-08-07 13:06 ` Jeff Layton
[not found] ` <20130807090616.6ba44d6c-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-08-07 13:42 ` David McBride
[not found] ` <52024EC3.2070504-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2013-08-08 14:05 ` Marcus Moeller
[not found] ` <5203A5B8.80600-OI3hZJvNYWs@public.gmane.org>
2013-08-08 14:22 ` Jeff Layton
[not found] ` <20130808102236.44424bf3-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-08-08 15:33 ` Steve French
[not found] ` <CAH2r5muc+5xpabeQYNJq5Vb2_2nAMof2EUUFbkMpoBsUX7MC+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-08-12 6:07 ` Marcus Moeller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52087BA1.4020307@gmx.ch \
--to=marcus.moeller-oi3hzjvnyws@public.gmane.org \
--cc=dwm37-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox