From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Gardner Subject: Re: [PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire Date: Fri, 01 Nov 2013 12:04:44 -0700 Message-ID: <5273FB4C.5010002@tpi.com> References: <1381941162-72831-1-git-send-email-timg@tpi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , samba-technical , LKML , Jeff Layton , Steve French To: Steve French Return-path: In-Reply-To: Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 11/01/2013 11:50 AM, Steve French wrote: > This has a couple of obvious endian errors. I will correct your patch > and remerge into cifs-2.6.git for-next > > Please always remember to run endian checks against cifs builds when > submitting a patch (and make sure sparse is installed) > > e.g. > > make C=1 M=fs/cifs modules CF=-D__CHECK_ENDIAN__ > Didn't know about __CHECK_ENDIAN__, but will do so in the future. Your changes look fine. rtg -- Tim Gardner timg-l6nL5VImRDY@public.gmane.org www.tpi.com OR 503-601-0234 x102 MT 406-443-5357