Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Orion Poplawski <orion-CVdf0l11yl+B+jHODAdFcQ@public.gmane.org>
To: Simo <simo-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Cc: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: pam module to set cifs credentials in key store
Date: Wed, 13 Nov 2013 15:50:31 -0700	[thread overview]
Message-ID: <52840237.2010206@cora.nwra.com> (raw)
In-Reply-To: <52840177.80901-CVdf0l11yl+B+jHODAdFcQ@public.gmane.org>

On 11/13/2013 03:47 PM, Orion Poplawski wrote:
> On 11/13/2013 03:34 PM, Simo wrote:
>>
>> Uhm doesn't this code store the user password in the clear in a key that
>> is explicitly made readable to any process of the user in the same
>> session ?
>>
>> Simo.
>>
>
> I tried to mimic exactly what the cifscreds program does, but I may have made
> a mistake.  Or perhaps cifscreds is also doing a bad thing.  The key
> permissions are set to:
>
> #define CIFS_KEY_PERMS (KEY_POS_VIEW|KEY_POS_WRITE|KEY_POS_SEARCH| \
>                          KEY_USR_VIEW|KEY_USR_WRITE|KEY_USR_SEARCH)
>
>

We're not setting KEY_*_READ, so one cannot read the contents of the key, IIUIC.

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion-CfuHcwXVrUc@public.gmane.org
Boulder, CO 80301                   http://www.nwra.com

  parent reply	other threads:[~2013-11-13 22:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 23:22 pam module to set cifs credentials in key store Orion Poplawski
     [not found] ` <loom.20131113T002139-562-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2013-11-13  2:25   ` Jeff Layton
     [not found]     ` <20131112212536.6061477e-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2013-11-13 20:59       ` Orion Poplawski
     [not found]         ` <5283E835.2090508-CVdf0l11yl+B+jHODAdFcQ@public.gmane.org>
2013-11-13 21:50           ` Jeff Layton
2013-11-13 22:34           ` Simo
     [not found]             ` <1384382099.4226.63.camel-fj0lwfvWodpMy5p6ylGyhR2eb7JE58TQ@public.gmane.org>
2013-11-13 22:47               ` Orion Poplawski
     [not found]                 ` <52840177.80901-CVdf0l11yl+B+jHODAdFcQ@public.gmane.org>
2013-11-13 22:50                   ` Orion Poplawski [this message]
     [not found]                     ` <52840237.2010206-CVdf0l11yl+B+jHODAdFcQ@public.gmane.org>
2013-11-13 23:32                       ` Simo
     [not found]                         ` <1384385539.4226.67.camel-fj0lwfvWodpMy5p6ylGyhR2eb7JE58TQ@public.gmane.org>
2013-11-14 13:08                           ` Jeff Layton
     [not found]                             ` <20131114080854.546b6069-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-11-14 16:15                               ` Simo
     [not found]                                 ` <1384445750.4226.71.camel-fj0lwfvWodpMy5p6ylGyhR2eb7JE58TQ@public.gmane.org>
2013-11-14 17:05                                   ` Jeff Layton
2013-11-30 10:32           ` Jeff Layton
     [not found]             ` <20131130053237.5ba7359d-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-12-02 19:36               ` [PATCH] cifs-utils: " Orion Poplawski
     [not found]                 ` <529CE146.8090202-CVdf0l11yl+B+jHODAdFcQ@public.gmane.org>
2013-12-07 14:06                   ` Jeff Layton
     [not found]                     ` <20131207090643.127cd0fe-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-12-10 21:23                       ` Orion Poplawski
2013-12-07 14:23                   ` Jeff Layton
     [not found]                     ` <20131207092341.16e0fe0c-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-12-10 12:21                       ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52840237.2010206@cora.nwra.com \
    --to=orion-cvdf0l11yl+b+jhodadfcq@public.gmane.org \
    --cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=simo-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox