Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: "Günter Kukkukk" <linux-KQewbsS9MvBBDgjK7y7TUQ@public.gmane.org>
To: Jeff Layton <jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] on 2nd try mount.cifs must also uppercase "orig_dev" - recent kernels now ignore "unc=..." mount option
Date: Tue, 01 Jul 2014 19:05:29 +0200	[thread overview]
Message-ID: <53B2EA59.8090404@kukkukk.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

userland mount helper mount.cifs.

Also uppercase the now used (kernel) "orig_dev" parameter, to get the
mount retry working again.

Cheers, Günter
-- 


[-- Attachment #2: 0001-on-2nd-try-mount.cifs-must-also-uppercase-orig_dev-r.patch --]
[-- Type: text/x-patch, Size: 1247 bytes --]

>From 5b6633b93b4df19b6c2863b8c9cf11d622132b60 Mon Sep 17 00:00:00 2001
From: Guenter Kukkukk <kukks-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Date: Tue, 1 Jul 2014 17:43:55 +0200
Subject: [PATCH] on 2nd try mount.cifs must also uppercase "orig_dev" - recent
 kernels now ignore "unc=..." mount option

mount.cifs.c, when getting errno=ENXIO, retries the mount with uppercased
hostname, sharename and prefixpath in the "unc=..." mount option, which
is ignored now in the kernel. Used e.g. during OS/2 mounts, which fail now.

Also uppercase the now used "orig_dev" parameter.

Signed-off-by: Guenter Kukkukk <kukks-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
---
 mount.cifs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mount.cifs.c b/mount.cifs.c
index 497665d..3535096 100644
--- a/mount.cifs.c
+++ b/mount.cifs.c
@@ -2097,7 +2097,8 @@ mount_retry:
 			if (!already_uppercased &&
 			    uppercase_string(parsed_info->host) &&
 			    uppercase_string(parsed_info->share) &&
-			    uppercase_string(parsed_info->prefix)) {
+			    uppercase_string(parsed_info->prefix) &&
+			    uppercase_string(orig_dev)) {
 				fprintf(stderr,
 					"Retrying with upper case share name\n");
 				already_uppercased = 1;
-- 
1.8.4.5


             reply	other threads:[~2014-07-01 17:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 17:05 Günter Kukkukk [this message]
     [not found] ` <53B2EA59.8090404-KQewbsS9MvBBDgjK7y7TUQ@public.gmane.org>
2014-07-01 17:14   ` [PATCH] on 2nd try mount.cifs must also uppercase "orig_dev" - recent kernels now ignore "unc=..." mount option Jeff Layton
2014-07-03 20:06   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B2EA59.8090404@kukkukk.com \
    --to=linux-kqewbss9mvbbdgjk7y7tuq@public.gmane.org \
    --cc=jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox