From: "PaX Team" <pageexec-Y8qEzhMunLyT9ig0jae3mg@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
re.emese-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
spender-JNS0hek0TMl4qEwOxq4T+Q@public.gmane.org
Subject: Re: question about potential integer truncation in cifs_set_file_size
Date: Tue, 29 Sep 2015 13:02:35 +0200 [thread overview]
Message-ID: <560A6FCB.6228.60A6C7EA@pageexec.freemail.hu> (raw)
In-Reply-To: <CAH2r5mvWtbsru8HAphsGhukP-YHNSF+99D9v1BbBbNMeiaeCAw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 28 Sep 2015 at 15:57, Steve French wrote:
> > FTR, this issue was detected with the upcoming version of the size overflow
> > plugin we have in PaX/grsecurity and there're a handful of similar cases in
> > the tree where potentially unwanted or unnecessary integer truncations occur,
> > this being one of these. any opinion/help is welcome!
>
> If you find others let me know (other than the identical bug in the
> error path immediately below the one you just pointed out).
sure, i will, though the current (very specific) analysis found only
those questionable cases that i reported (here and some other lists).
if you (or anyone else) have ideas for more specific analysis (checking
invariants, API use, etc), we can take a look though gcc plugins have
very limited view on the source code, so only those properties can be
checked that are still visible in the middle end (we found the above
case exactly because the underlying code looks the same whether the
integer truncation is intentional or not, so we had to exclude them
as false positives in our instrumentation but still wanted to manually
verify them).
PS: it seems that you didn't CC me on the actual patch ;)
prev parent reply other threads:[~2015-09-29 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 14:31 question about potential integer truncation in cifs_set_file_size PaX Team
[not found] ` <5606AC37.16935.51F2ED39-tVCe0bXVy/VhMnff8nq0I0CAg8bcNmFB@public.gmane.org>
2015-09-28 20:57 ` Steve French
[not found] ` <CAH2r5mvWtbsru8HAphsGhukP-YHNSF+99D9v1BbBbNMeiaeCAw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-29 11:02 ` PaX Team [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560A6FCB.6228.60A6C7EA@pageexec.freemail.hu \
--to=pageexec-y8qezhmunlyt9ig0jae3mg@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=re.emese-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=spender-JNS0hek0TMl4qEwOxq4T+Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox