Re: [PATCH] smb: client: tighten validate_t2() offset bounds against actual buffer size

[Paulo Alcantara <pc@manguebit.org>]

Frank Sorenson <sorenson@redhat.com> writes:

> On 8/26/26 6:03 PM, Paulo Alcantara wrote:
>> Besides all these LLM-generated messages and comments, would you have a
>> reproducer or a real use case that would require such changes?
>
> I just want to apologize for going so far overboard.  I identified a
> potential type of issue, and then kept expanding the scope without
> finding a concrete problem or reproducer.  That's a definite
> overcorrection; I tried to fix things that have no known impact in
> practice ('malicious SMB1 server' is a pretty weak threat).
>
> And as you noted, I relied too heavily on AI assistance; that's on
> me.  I'll be more careful about both the scope of what I do and how
> I get there.
>
> I'll obviously withdraw this

Oh Frank, that's fine.  No worries.

My only concern is that this SMB1 code, and as much as we can avoid it,
the better.  The bugs are still valid to be reviewed and fixed, whether
we like it or not.

If we could have reproducers or any other way to validate them, great.
Otherwise, it's fine too -- we can fix any regressions later.

A few days ago we were struggling with getting diretory listing fixed
against Windows XP server because of a cleanup patch that touched SMB1
code that had been working for a very long time...

I'll help you with that.  Great work.