From: ChenXiaoSong <chenxiaosong@chenxiaosong.com>
To: Werner Kasselman <werner@verivus.ai>,
"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>
Cc: "linkinjeon@kernel.org" <linkinjeon@kernel.org>,
"smfrench@gmail.com" <smfrench@gmail.com>,
"senozhatsky@chromium.org" <senozhatsky@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] ksmbd: fix use-after-free and NULL deref in smb_grant_oplock()
Date: Tue, 17 Mar 2026 14:32:57 +0800 [thread overview]
Message-ID: <6b98c261-b17b-45a8-ab09-efdb0d658f4e@chenxiaosong.com> (raw)
In-Reply-To: <20260317021757.962692-1-werner@verivus.com>
Hi Werner,
Thanks for your patch. It seems the changes below are not included. Do
you have any follow-up patches that haven't been submitted yet?
Thanks,
ChenXiaoSong <chenxiaosong@chenxiaosong.com>
在 2026/3/17 10:18, Werner Kasselman 写道:
> - Preallocate lease_table via alloc_lease_table() before opinfo_add()
> so add_lease_global_list() becomes infallible after publication.
> - Keep the original m_op_list publication order (opinfo_add before
> lease list) so concurrent opens via same_client_has_lease() and
> opinfo_get_list() still see the in-flight grant.
> - Use opinfo_put() instead of __free_opinfo() on err_out so that
> the RCU-deferred free path is used.
>
> This also requires splitting add_lease_global_list() to take a
> preallocated lease_table and changing its return type from int to void,
> since it can no longer fail.
next prev parent reply other threads:[~2026-03-17 6:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 2:18 [PATCH] ksmbd: fix use-after-free and NULL deref in smb_grant_oplock() Werner Kasselman
2026-03-17 6:32 ` ChenXiaoSong [this message]
2026-03-17 6:36 ` Werner Kasselman
2026-03-17 6:43 ` ChenXiaoSong
2026-03-17 6:53 ` Werner Kasselman
-- strict thread matches above, loose matches on Subject: below --
2026-03-17 13:00 Werner Kasselman
2026-03-17 13:48 ` ChenXiaoSong
2026-03-17 20:07 ` Werner Kasselman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b98c261-b17b-45a8-ab09-efdb0d658f4e@chenxiaosong.com \
--to=chenxiaosong@chenxiaosong.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=stable@vger.kernel.org \
--cc=werner@verivus.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox