From: Paulo Alcantara <pc@manguebit.org>
To: linux-cifs@vger.kernel.org, netfs@lists.linux.dev
Cc: David Howells <dhowells@redhat.com>,
Christian Brauner <brauner@kernel.org>,
Namjae Jeon <linkinjeon@kernel.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>, Bharath SM <bharathsm@microsoft.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/5] smb: client: discard post-EOF pagecache when extending a file via truncate
Date: Mon, 21 Sep 2026 13:48:26 -0300 [thread overview]
Message-ID: <6e4432d117a597ae07c295c30164364a@manguebit.org> (raw)
In-Reply-To: <20260921154957.903891-2-pc@manguebit.org>
Paulo Alcantara <pc@manguebit.org> writes:
> cifs_setsize() relied on pagecache_isize_extended() to zero the tail of
> the folio straddling the old EOF, but that helper is a no-op on CIFS
> (i_blkbits is 14), so data dirtied past EOF through an mmap survived and
> became visible once the file was extended.
>
> Drop that call and lower the truncate_pagecache() boundary to the smaller
> of the old and new sizes, which is block-size independent and reliably
> discards the pagecache beyond the old EOF.
> ...
I'll address Sashiko's comments [1] for this patch and 1/5. Please
ignore the whole series for now.
[1] https://sashiko.dev/#/patchset/20260921154957.903891-1-pc%40manguebit.org
next prev parent reply other threads:[~2026-09-21 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:49 [PATCH 1/5] netfs: discard post-EOF pagecache when extending a file via write Paulo Alcantara
2026-09-21 15:49 ` [PATCH 2/5] smb: client: discard post-EOF pagecache when extending a file via truncate Paulo Alcantara
2026-09-21 16:48 ` Paulo Alcantara [this message]
2026-09-21 15:49 ` [PATCH 3/5] smb: client: discard post-EOF pagecache when extending a file via zero range Paulo Alcantara
2026-09-21 15:49 ` [PATCH 4/5] smb: client: discard post-EOF pagecache when extending a file via copy range Paulo Alcantara
2026-09-21 15:49 ` [PATCH 5/5] smb: client: discard post-EOF pagecache when extending a file via clone range Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e4432d117a597ae07c295c30164364a@manguebit.org \
--to=pc@manguebit.org \
--cc=bharathsm@microsoft.com \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=ronniesahlberg@gmail.com \
--cc=sprasad@microsoft.com \
--cc=stable@vger.kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox