From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Ariel Elior <aelior@marvell.com>,
Anna Schumaker <anna@kernel.org>, Jens Axboe <axboe@fb.com>,
Christian Benvenuti <benve@cisco.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Bernard Metzler <bmt@zurich.ibm.com>,
Bart Van Assche <bvanassche@acm.org>,
Chuck Lever <chuck.lever@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <kch@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>,
Leon Romanovsky <leon@kernel.org>,
linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Michal Kalderon <mkalderon@marvell.com>,
Mustafa Ismail <mustafa.ismail@intel.com>,
Nelson Escobar <neescoba@cisco.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
rds-devel@oss.oracle.com, Sagi Grimberg <sagi@grimberg.me>,
samba-technical@lists.samba.org,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Steve French <sfrench@samba.org>,
Shiraz Saleem <shiraz.saleem@intel.com>,
target-devel@vger.kernel.org,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Yishai Hadas <yishaih@nvidia.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: Re: [PATCH v2] RDMA: Split kernel-only global device caps from uverbs device caps
Date: Thu, 7 Apr 2022 10:09:04 +0300 [thread overview]
Message-ID: <6f577f5e-deb8-b961-ef45-1aa31f440578@nvidia.com> (raw)
In-Reply-To: <20220406215431.GK2120790@nvidia.com>
On 4/7/2022 12:54 AM, Jason Gunthorpe wrote:
> On Thu, Apr 07, 2022 at 12:01:44AM +0300, Max Gurtovoy wrote:
>
>>> @@ -267,59 +258,53 @@ enum ib_device_cap_flags {
>>> * stag.
>>> */
>>> IB_DEVICE_MEM_MGT_EXTENSIONS = IB_UVERBS_DEVICE_MEM_MGT_EXTENSIONS,
>> MEM_MGT_EXTENSIONS is used also in the kernel ULPs (storage)
> It is not about where it is used, it is about if it is part of the
> uapi or not. Cleanly separating uapi from not uapi
from the commit message:
"
This cleanly splits out the uverbs flags from the kernel flags to avoid
confusion in the flags bitmap.
"
so it was not clear, at least to me, that some user flags are part of
both the uapi and the kapi.
maybe worth mentioning that or split the uapi and kapi altogether.
Anyway looks good for iser/srp/nvmf,
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>
> Jason
next prev parent reply other threads:[~2022-04-07 7:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 19:27 [PATCH v2] RDMA: Split kernel-only global device caps from uverbs device caps Jason Gunthorpe
2022-04-06 19:57 ` Bart Van Assche
2022-04-07 15:52 ` Jason Gunthorpe
2022-04-07 16:10 ` Leon Romanovsky
2022-04-07 16:28 ` Jason Gunthorpe
2022-04-06 21:01 ` Max Gurtovoy
2022-04-06 21:54 ` Jason Gunthorpe
2022-04-07 7:09 ` Max Gurtovoy [this message]
2022-04-07 15:49 ` Jason Gunthorpe
2022-04-07 5:37 ` Christoph Hellwig
2022-04-08 16:45 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f577f5e-deb8-b961-ef45-1aa31f440578@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=aelior@marvell.com \
--cc=anna@kernel.org \
--cc=axboe@fb.com \
--cc=benve@cisco.com \
--cc=bharat@chelsio.com \
--cc=bmt@zurich.ibm.com \
--cc=bvanassche@acm.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=mkalderon@marvell.com \
--cc=mustafa.ismail@intel.com \
--cc=neescoba@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=sagi@grimberg.me \
--cc=samba-technical@lists.samba.org \
--cc=santosh.shilimkar@oracle.com \
--cc=selvin.xavier@broadcom.com \
--cc=sfrench@samba.org \
--cc=shiraz.saleem@intel.com \
--cc=target-devel@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=yishaih@nvidia.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox